linux-kernel - Re: [PATCH 2/2] spi: rockchip-sfc: Add rockchip,fspi compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1ef2ece5-f4ed-46ca-9bf5-75f898565a62@kernel.org>
Date: Wed, 8 Jan 2025 08:03:28 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jon Lin <jon.lin@...k-chips.com>, broonie@...nel.org
Cc: linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
 heiko@...ech.de, linux-arm-kernel@...ts.infradead.org,
 linux-spi@...r.kernel.org
Subject: Re: [PATCH 2/2] spi: rockchip-sfc: Add rockchip,fspi compatible

On 07/01/2025 16:47, Jon Lin wrote:
> 
> diff --git a/drivers/spi/spi-rockchip-sfc.c b/drivers/spi/spi-rockchip-sfc.c
> index 59de351499a0..88fbde27925e 100644
> --- a/drivers/spi/spi-rockchip-sfc.c
> +++ b/drivers/spi/spi-rockchip-sfc.c
> @@ -808,6 +808,7 @@ static const struct dev_pm_ops rockchip_sfc_pm_ops = {
>  };
>  
>  static const struct of_device_id rockchip_sfc_dt_ids[] = {
> +	{ .compatible = "rockchip,fspi"},
>  	{ .compatible = "rockchip,sfc"},
I don't understand why you are adding generic compatible which is not
even used. Use proper SoC specific compatibles and fallbacks when
applicable (see writing bindings document).

Best regards,
Krzysztof