linux-kernel - Re: [PATCH v5 3/5] dt-bindings: PCI: qcom: Document the IPQ5332 PCIe controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50b03189-bf2c-46c8-b7c2-4aa5eed97c35@kernel.org>
Date: Wed, 8 Jan 2025 08:19:19 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Varadarajan Narayanan <quic_varada@...cinc.com>
Cc: bhelgaas@...gle.com, lpieralisi@...nel.org, kw@...ux.com,
 manivannan.sadhasivam@...aro.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, vkoul@...nel.org, kishon@...nel.org,
 andersson@...nel.org, konradybcio@...nel.org, p.zabel@...gutronix.de,
 quic_nsekar@...cinc.com, dmitry.baryshkov@...aro.org,
 linux-arm-msm@...r.kernel.org, linux-pci@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-phy@...ts.infradead.org
Subject: Re: [PATCH v5 3/5] dt-bindings: PCI: qcom: Document the IPQ5332 PCIe
 controller

On 07/01/2025 12:05, Varadarajan Narayanan wrote:
>>> ---
>>>  Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 10 ++++++++--
>>>  1 file changed, 8 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>>> index bd87f6b49d68..9f37eca1ce0d 100644
>>> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>>> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>>> @@ -26,7 +26,6 @@ properties:
>>>            - qcom,pcie-ipq8064-v2
>>>            - qcom,pcie-ipq8074
>>>            - qcom,pcie-ipq8074-gen3
>>> -          - qcom,pcie-ipq9574
>>
>> I don't understand this change at all and your commit msg explains
>> here nothing.
> 
> All DT entries except "reg" is similar between ipq5332 and
> ipq9574. ipq9574 has 5 registers while ipq5332 has 6. MHI is the
> additional (i.e. sixth) entry for ipq5332.
> 
> If ipq9574 is not removed from here, dt_binding_check gives the
> following errors
> 
> 1.	/local/mnt/workspace/varada/upstream/pci-v6/arch/arm64/boot/dts/qcom/ipq5332-rdp474.dtb: pcie@...00000: reg: [[557056, 12288], [402653184, 3869], [402657056, 168], [402657280, 4096], [403701760, 4096], [569344, 4096]] is too long
> 
> 	Failed validating 'maxItems' in schema['allOf'][2]['then']['properties']['reg']:
> 	    {'maxItems': 5, 'minItems': 5}
> 
> 2.	/local/mnt/workspace/varada/upstream/pci-v6/arch/arm64/boot/dts/qcom/ipq5332-rdp474.dtb: pcie@...00000: reg-names: ['parf', 'dbi', 'elbi', 'atu', 'config', 'mhi'] is too long
> 
> 	Failed validating 'maxItems' in schema['allOf'][2]['then']['properties']['reg-names']:
> 	    {'items': [{'const': 'dbi'},
> 		       {'const': 'elbi'},
> 		       {'const': 'atu'},
> 		       {'const': 'parf'},
> 		       {'const': 'config'}],
> 	     'maxItems': 5,
> 	     'minItems': 5,
> 	     'type': 'array'}
> 
> Hence had to remove it from here and add it to the sdx55 reg
> definition.

So you entirely dropped constrain for regs. No. This has to be fixed,
not dropped.
Best regards,
Krzysztof