linux-kernel - Re: [PATCH] efi: sysfb_efi: fix W=1 warnings when EFI is not set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zfk1iuk9.fsf@minerva.mail-host-address-is-not-set>
Date: Wed, 08 Jan 2025 09:22:30 +0100
From: Javier Martinez Canillas <javierm@...hat.com>
To: Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc: Randy Dunlap <rdunlap@...radead.org>, kernel test robot <lkp@...el.com>,
 David Rheinsberg <david@...dahead.eu>, Hans de Goede
 <hdegoede@...hat.com>, Peter Jones <pjones@...hat.com>, Simona Vetter
 <simona@...ll.ch>, linux-fbdev@...r.kernel.org, Ard Biesheuvel
 <ardb@...nel.org>, linux-efi@...r.kernel.org
Subject: Re: [PATCH] efi: sysfb_efi: fix W=1 warnings when EFI is not set

Randy Dunlap <rdunlap@...radead.org> writes:

Hello Randy,

> A build with W=1 fails because there are code and data that are not
> needed or used when CONFIG_EFI is not set. Move the "#ifdef CONFIG_EFI"
> block to earlier in the source file so that the unused code/data are
> not built.
>
> drivers/firmware/efi/sysfb_efi.c:345:39: warning: ‘efifb_fwnode_ops’ defined but not used [-Wunused-const-variable=]
>   345 | static const struct fwnode_operations efifb_fwnode_ops = {
>       |                                       ^~~~~~~~~~~~~~~~
> drivers/firmware/efi/sysfb_efi.c:238:35: warning: ‘efifb_dmi_swap_width_height’ defined but not used [-Wunused-const-variable=]
>   238 | static const struct dmi_system_id efifb_dmi_swap_width_height[] __initconst = {
>       |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/firmware/efi/sysfb_efi.c:188:35: warning: ‘efifb_dmi_system_table’ defined but not used [-Wunused-const-variable=]
>   188 | static const struct dmi_system_id efifb_dmi_system_table[] __initconst = {
>       |                                   ^~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: 15d27b15de96 ("efi: sysfb_efi: fix build when EFI is not set")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202501071933.20nlmJJt-lkp@intel.com/
> Cc: David Rheinsberg <david@...dahead.eu>
> Cc: Hans de Goede <hdegoede@...hat.com>
> Cc: Javier Martinez Canillas <javierm@...hat.com>
> Cc: Peter Jones <pjones@...hat.com>
> Cc: Simona Vetter <simona@...ll.ch>
> Cc: linux-fbdev@...r.kernel.org
> Cc: Ard Biesheuvel <ardb@...nel.org>
> Cc: linux-efi@...r.kernel.org
> ---
>  drivers/firmware/efi/sysfb_efi.c |    2 +-

Reviewed-by: Javier Martinez Canillas <javierm@...hat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat