linux-kernel - Re: [PATCH v4 1/3] dt-bindings: soc: samsung: usi: add USIv1 and samsung,exynos8895-usi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ataxete4izo3hpyuqve3isktvvbuwoosc6burnkhqcratfgv4c@ycejvdx6k3cr>
Date: Wed, 8 Jan 2025 09:30:21 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ivaylo Ivanov <ivo.ivanov.ivanov1@...il.com>
Cc: Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Alim Akhtar <alim.akhtar@...sung.com>, Sam Protsenko <semen.protsenko@...aro.org>, 
	Peter Griffin <peter.griffin@...aro.org>, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/3] dt-bindings: soc: samsung: usi: add USIv1 and
 samsung,exynos8895-usi

On Tue, Jan 07, 2025 at 01:35:10PM +0200, Ivaylo Ivanov wrote:
> Add new constants for choosing the additional USIv1 configuration modes
> in device tree. Those are further used in the USI driver to figure out
> which value to write into SW_CONF register. Modify the current USI IP-core
> bindings to include information about USIv1 and a compatible for
> exynos8895.
> 
> In the original bindings commit, protocol mode definitions were named
> with the version of the supported USI (in this case, V2) with the idea of
> leaving enough room in the future for other versions of this block. This,
> however, is not how the modes should be modelled. The modes are not
> version specific and you should not be able to tell USI which version of
> a mode to use - that has to be handled in the driver - thus encoding this
> information in the binding is meaningless. Only one constant per mode is
> needed, so while we're at it, add new constants with the prefix USI_MODE
> and mark the old ones as depracated.
> 
> Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@...il.com>
> ---
>  .../bindings/soc/samsung/exynos-usi.yaml      | 99 ++++++++++++-------
>  include/dt-bindings/soc/samsung,exynos-usi.h  | 17 +++-
>  2 files changed, 79 insertions(+), 37 deletions(-)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof