linux-kernel - Re: [PATCH v5 11/17] x86: pgtable: convert __tlb_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7cf8fa3b-799f-415a-82a1-eee6b7b2e0f5@arm.com>
Date: Wed, 8 Jan 2025 09:31:06 +0100
From: Kevin Brodsky <kevin.brodsky@....com>
To: Qi Zheng <zhengqi.arch@...edance.com>, peterz@...radead.org,
 agordeev@...ux.ibm.com, alex@...ti.fr, andreas@...sler.com,
 palmer@...belt.com, tglx@...utronix.de, david@...hat.com, jannh@...gle.com,
 hughd@...gle.com, yuzhao@...gle.com, willy@...radead.org,
 muchun.song@...ux.dev, vbabka@...nel.org, lorenzo.stoakes@...cle.com,
 akpm@...ux-foundation.org, rientjes@...gle.com, vishal.moola@...il.com,
 arnd@...db.de, will@...nel.org, aneesh.kumar@...nel.org, npiggin@...il.com,
 dave.hansen@...ux.intel.com, rppt@...nel.org, ryan.roberts@....com
Cc: linux-mm@...ck.org, linux-arm-kernel@...ts.infradead.org,
 linuxppc-dev@...ts.ozlabs.org, linux-riscv@...ts.infradead.org,
 linux-s390@...r.kernel.org, sparclinux@...r.kernel.org,
 linux-kernel@...r.kernel.org, x86@...nel.org, linux-arch@...r.kernel.org,
 linux-csky@...r.kernel.org, linux-hexagon@...r.kernel.org,
 loongarch@...ts.linux.dev, linux-m68k@...ts.linux-m68k.org,
 linux-mips@...r.kernel.org, linux-openrisc@...r.kernel.org,
 linux-sh@...r.kernel.org, linux-um@...ts.infradead.org
Subject: Re: [PATCH v5 11/17] x86: pgtable: convert __tlb_remove_table() to
 use struct ptdesc

On 08/01/2025 07:57, Qi Zheng wrote:
> Convert __tlb_remove_table() to use struct ptdesc, which will help to move
> pagetable_dtor() to __tlb_remove_table().
>
> And page tables shouldn't have swap cache, so use pagetable_free() instead
> of free_page_and_swap_cache() to free page table pages.
>
> Signed-off-by: Qi Zheng <zhengqi.arch@...edance.com>

Definitely a good idea to have split patch 11 from v4.

Reviewed-by: Kevin Brodsky <kevin.brodsky@....com>

- Kevin