linux-kernel - RE: [PATCH] arm64: dts: socfpga: agilex5: add clock-names property to nand node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BL3PR11MB6532F7F7897B5A808158CB49A2122@BL3PR11MB6532.namprd11.prod.outlook.com>
Date: Wed, 8 Jan 2025 10:00:06 +0000
From: "Rabara, Niravkumar L" <niravkumar.l.rabara@...el.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Dinh Nguyen <dinguyen@...nel.org>,
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] arm64: dts: socfpga: agilex5: add clock-names property to
 nand node



> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: Wednesday, 8 January, 2025 3:14 PM
> To: Rabara, Niravkumar L <niravkumar.l.rabara@...el.com>; Dinh Nguyen
> <dinguyen@...nel.org>; Rob Herring <robh@...nel.org>; Krzysztof Kozlowski
> <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH] arm64: dts: socfpga: agilex5: add clock-names property
> to nand node
> 
> On 07/01/2025 11:21, Rabara, Niravkumar L wrote:
> >
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzk@...nel.org>
> >> Sent: Tuesday, 7 January, 2025 5:21 PM
> >> To: Rabara, Niravkumar L <niravkumar.l.rabara@...el.com>; Dinh Nguyen
> >> <dinguyen@...nel.org>; Rob Herring <robh@...nel.org>; Krzysztof
> >> Kozlowski <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>;
> >> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org
> >> Subject: Re: [PATCH] arm64: dts: socfpga: agilex5: add clock-names
> >> property to nand node
> >>
> >> On 07/01/2025 09:49, niravkumar.l.rabara@...el.com wrote:
> >>> From: Niravkumar L Rabara <niravkumar.l.rabara@...el.com>
> >>>
> >>> Cadence nand controller driver requires clock-names = "nf_clk" property.
> >>>
> >>
> >> Fixes tag.
> >>
> >>> Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@...el.com>
> >>> ---
> >>>  arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi | 1 +
> >>>  1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> >>> b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> >>> index 51c6e19e40b8..4357572e96e3 100644
> >>> --- a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> >>> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> >>> @@ -272,6 +272,7 @@ nand: nand-controller@...80000 {
> >>>  			interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
> >>>  			clocks = <&clkmgr AGILEX5_NAND_NF_CLK>;
> >>>  			cdns,board-delay-ps = <4830>;
> >>> +			clock-names = "nf_clk";
> >>
> >> It does not look like you tested the DTS against bindings. Please run
> >> `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-
> >> schema.rst or
> >> https://www.linaro.org/blog/tips-and-tricks-for-validating-
> >> devicetree-sources-with-the-devicetree-schema/
> >> for instructions).
> >> Maybe you need to update your dtschema and yamllint. Don't rely on
> >> distro packages for dtschema and be sure you are using the latest
> >> released dtschema.
> >
> > I believe you are pointing to this error message
> > /soc@...and-controller@...80000: failed to match any schema with
> > compatible: ['cdns,hp-nfc']
> >
> 
> No. I refer to this clock-names property. As you can easily see in the
> binding: there is no clock-names.
> 
Got it. I need to update binding with clock-names property first. 

Thanks,
Nirav