linux-kernel - Re: [PATCH] clk: qcom: clk-rpmh: add explicit casting in clk_rpmh_bcm_recalc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a90660d8-1f1b-4497-a470-03ae00272ee7@astralinux.ru>
Date: Thu, 9 Jan 2025 16:57:20 +0300
From: Anastasia Belova <abelova@...ralinux.ru>
To: Fedor Pchelkin <pchelkin@...ras.ru>
Cc: Bjorn Andersson <andersson@...nel.org>, lvc-project@...uxtesting.org,
 Stephen Boyd <sboyd@...nel.org>, linux-arm-msm@...r.kernel.org,
 Michael Turquette <mturquette@...libre.com>,
 David Dai <daidavid1@...eaurora.org>, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH] clk: qcom: clk-rpmh: add explicit casting in
 clk_rpmh_bcm_recalc_rate

Right, I'm sorry to bother you


On 1/9/25 3:31 PM, Fedor Pchelkin wrote:
> On Thu, 09. Jan 13:52, Anastasia Belova wrote:
>> The result of multiplication of aggr_state and unit fields (rate
>> value) may not fit u32 type. Add explicit casting to a larger
>> type to prevent overflow.
>>
>> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>>
>> Fixes: 04053f4d23a4 ("clk: qcom: clk-rpmh: Add IPA clock support")
>> Cc: stable@...r.kernel.org # v5.4+
>> Signed-off-by: Anastasia Belova <abelova@...ralinux.ru>
>> ---
> Already applied here [1], no?
>
> [1]: https://lore.kernel.org/lkml/173525273254.1449028.13893672295374918386.b4-ty@kernel.org/
>
>>   drivers/clk/qcom/clk-rpmh.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
>> index eefc322ce367..e6c33010cfbf 100644
>> --- a/drivers/clk/qcom/clk-rpmh.c
>> +++ b/drivers/clk/qcom/clk-rpmh.c
>> @@ -329,7 +329,7 @@ static unsigned long clk_rpmh_bcm_recalc_rate(struct clk_hw *hw,
>>   {
>>   	struct clk_rpmh *c = to_clk_rpmh(hw);
>>   
>> -	return c->aggr_state * c->unit;
>> +	return (unsigned long)c->aggr_state * c->unit;
>>   }
>>   
>>   static const struct clk_ops clk_rpmh_bcm_ops = {
>> -- 
>> 2.43.0