linux-kernel - Re: [PATCH v3] HID: lenovo: Support for ThinkPad-X12-TAB-1/2 Kbd Fn keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <r9p69o0r-626q-950r-o73r-p67r88nrp70n@xreary.bet>
Date: Thu, 9 Jan 2025 15:12:37 +0100 (CET)
From: Jiri Kosina <jikos@...nel.org>
To: Benjamin Tissoires <bentiss@...nel.org>
cc: Vishnu Sankar <vishnuocv@...il.com>, linux-input@...r.kernel.org, 
    linux-kernel@...r.kernel.org, mpearson-lenovo@...ebb.ca, 
    vsankar@...ovo.com
Subject: Re: [PATCH v3] HID: lenovo: Support for ThinkPad-X12-TAB-1/2 Kbd Fn
 keys

On Thu, 9 Jan 2025, Benjamin Tissoires wrote:

> > +		/* Power-mode or Airplane mode will be called based on the device*/
> > +		case TP_X12_RAW_HOTKEY_FN_F8:
> > +			/*
> > +			 * TP X12 TAB uses Fn-F8 calls Airplanemode
> > +			 * Whereas TP X12 TAB2 uses Fn-F8 for toggling
> > +			 * Power modes
> > +			 */
> > +			(hdev->product == USB_DEVICE_ID_LENOVO_X12_TAB) ?
> > +				report_key_event(input, KEY_RFKILL) :
> > +				platform_profile_cycle();
> 
> Hey,
> 
> FWIW, this broke the CI with [0]:
> ERROR: modpost: "platform_profile_cycle" [drivers/hid/hid-lenovo.ko] undefined!
> 
> We are likely missing a DEPENDS or a SELECT in the Kconfig

Thanks for catching it!

Alternatively, we can just make the TP_X12_RAW_HOTKEY_FN_F8 case 
conditional on CONFIG_ACPI_PLATFORM_PROFILE.

Vishnu, can you please send a fixup patch?

Thanks,

-- 
Jiri Kosina
SUSE Labs