linux-kernel - Re: [PATCH v3] HID: lenovo: Support for ThinkPad-X12-TAB-1/2 Kbd Fn keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABxCQKvEOwZVnbCpuW0rdDEQuwq-ihReG6Jnw8f3TcYMvoPJzA@mail.gmail.com>
Date: Fri, 10 Jan 2025 10:08:39 +0900
From: Vishnu Sankar <vishnuocv@...il.com>
To: Jiri Kosina <jikos@...nel.org>
Cc: Benjamin Tissoires <bentiss@...nel.org>, linux-input@...r.kernel.org, 
	linux-kernel@...r.kernel.org, mpearson-lenovo@...ebb.ca, vsankar@...ovo.com
Subject: Re: [PATCH v3] HID: lenovo: Support for ThinkPad-X12-TAB-1/2 Kbd Fn keys

 Thanks a lot, Benchamin and Jiri for the suggestions.
I will send a fixup patch to solve "ERROR: modpost:
"platform_profile_cycle" [drivers/hid/hid-lenovo.ko] undefined!"
issue.

Thank You!

On Thu, Jan 9, 2025 at 11:12 PM Jiri Kosina <jikos@...nel.org> wrote:
>
> On Thu, 9 Jan 2025, Benjamin Tissoires wrote:
>
> > > +           /* Power-mode or Airplane mode will be called based on the device*/
> > > +           case TP_X12_RAW_HOTKEY_FN_F8:
> > > +                   /*
> > > +                    * TP X12 TAB uses Fn-F8 calls Airplanemode
> > > +                    * Whereas TP X12 TAB2 uses Fn-F8 for toggling
> > > +                    * Power modes
> > > +                    */
> > > +                   (hdev->product == USB_DEVICE_ID_LENOVO_X12_TAB) ?
> > > +                           report_key_event(input, KEY_RFKILL) :
> > > +                           platform_profile_cycle();
> >
> > Hey,
> >
> > FWIW, this broke the CI with [0]:
> > ERROR: modpost: "platform_profile_cycle" [drivers/hid/hid-lenovo.ko] undefined!
> >
> > We are likely missing a DEPENDS or a SELECT in the Kconfig
>
> Thanks for catching it!
>
> Alternatively, we can just make the TP_X12_RAW_HOTKEY_FN_F8 case
> conditional on CONFIG_ACPI_PLATFORM_PROFILE.
>
> Vishnu, can you please send a fixup patch?
>
> Thanks,
>
> --
> Jiri Kosina
> SUSE Labs
>


-- 

Regards,

      Vishnu Sankar
     +817015150407 (Japan)