linux-kernel - Re: [PATCH] treewide: const qualify ctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250109095037.0ac3fe09@gandalf.local.home>
Date: Thu, 9 Jan 2025 09:50:37 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Joel Granados <joel.granados@...nel.org>
Cc: Thomas Weißschuh <linux@...ssschuh.net>, Kees Cook
 <kees@...nel.org>, Luis Chamberlain <mcgrof@...nel.org>,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linuxppc-dev@...ts.ozlabs.org, linux-riscv@...ts.infradead.org,
 linux-s390@...r.kernel.org, linux-crypto@...r.kernel.org,
 openipmi-developer@...ts.sourceforge.net, intel-gfx@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org, intel-xe@...ts.freedesktop.org,
 linux-hyperv@...r.kernel.org, linux-rdma@...r.kernel.org,
 linux-raid@...r.kernel.org, linux-scsi@...r.kernel.org,
 linux-serial@...r.kernel.org, xen-devel@...ts.xenproject.org,
 linux-aio@...ck.org, linux-fsdevel@...r.kernel.org, netfs@...ts.linux.dev,
 codalist@...a.cs.cmu.edu, linux-mm@...ck.org, linux-nfs@...r.kernel.org,
 ocfs2-devel@...ts.linux.dev, fsverity@...ts.linux.dev,
 linux-xfs@...r.kernel.org, io-uring@...r.kernel.org, bpf@...r.kernel.org,
 kexec@...ts.infradead.org, linux-trace-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org, apparmor@...ts.ubuntu.com,
 linux-security-module@...r.kernel.org, keyrings@...r.kernel.org
Subject: Re: [PATCH] treewide: const qualify ctl_tables where applicable

On Thu, 09 Jan 2025 14:16:39 +0100
Joel Granados <joel.granados@...nel.org> wrote:

> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index 2e113f8b13a2..489cbab3d64c 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -8786,7 +8786,7 @@ ftrace_enable_sysctl(const struct ctl_table *table, int write,
>  	return ret;
>  }
>  
> -static struct ctl_table ftrace_sysctls[] = {
> +static const struct ctl_table ftrace_sysctls[] = {
>  	{
>  		.procname       = "ftrace_enabled",
>  		.data           = &ftrace_enabled,
> diff --git a/kernel/trace/trace_events_user.c b/kernel/trace/trace_events_user.c
> index 17bcad8f79de..97325fbd6283 100644
> --- a/kernel/trace/trace_events_user.c
> +++ b/kernel/trace/trace_events_user.c
> @@ -2899,7 +2899,7 @@ static int set_max_user_events_sysctl(const struct ctl_table *table, int write,
>  	return ret;
>  }
>  
> -static struct ctl_table user_event_sysctls[] = {
> +static const struct ctl_table user_event_sysctls[] = {
>  	{
>  		.procname	= "user_events_max",
>  		.data		= &max_user_events,

Acked-by: Steven Rostedt (Google) <rostedt@...dmis.org> # for kernel/trace/

-- Steve