linux-kernel - Re: [PATCH] staging: greybus: remove unnecessary parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46653b18-42b1-4511-afad-4f5a15e2fceb@ieee.org>
Date: Thu, 9 Jan 2025 08:54:30 -0600
From: Alex Elder <elder@...e.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Will Walsh <iron.will.walsh@...il.com>,
 Vaibhav Agarwal <vaibhav.sr@...il.com>, Mark Greer <mgreer@...malcreek.com>,
 Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 greybus-dev@...ts.linaro.org, linux-staging@...ts.linux.dev,
 linux-kernel@...r.kernel.org, outreachy@...ts.linux.dev
Subject: Re: [PATCH] staging: greybus: remove unnecessary parentheses

On 1/9/25 1:45 AM, Dan Carpenter wrote:
> On Wed, Jan 08, 2025 at 08:56:50PM -0600, Alex Elder wrote:
>> On 1/8/25 6:36 PM, Will Walsh wrote:
>>> Unnecessary parentheses in boolean comparisons make it harder to read.
>>>
>>> Removed the extra parentheses on line 305 for code readability.
>>>
>>> Signed-off-by: Will Walsh <iron.will.walsh@...il.com>
>>
>> I'm not sure this makes a big difference in readability but I
>> personally avoid extra parentheses unless adding them makes a
>> compiler warning go away.
> 
> It's not a compiler warning, it checkpatch.

I meant compiler "-Wparentheses" warnings, like "suggest
parentheses around ‘+’ inside ‘<<’".

But anyway, I have no problem with this being rejected,
it doesn't really add value, and to some, it subtracts.

					-Alex

> 
> regards,
> dan carpenter
>