linux-kernel - Re: [PATCH] staging: greybus: remove unnecessary parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025010932-rice-landed-2b96@gregkh>
Date: Thu, 9 Jan 2025 08:50:34 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Alex Elder <elder@...e.org>, Will Walsh <iron.will.walsh@...il.com>,
	Vaibhav Agarwal <vaibhav.sr@...il.com>,
	Mark Greer <mgreer@...malcreek.com>,
	Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
	greybus-dev@...ts.linaro.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org, outreachy@...ts.linux.dev
Subject: Re: [PATCH] staging: greybus: remove unnecessary parentheses

On Thu, Jan 09, 2025 at 10:45:50AM +0300, Dan Carpenter wrote:
> On Wed, Jan 08, 2025 at 08:56:50PM -0600, Alex Elder wrote:
> > On 1/8/25 6:36 PM, Will Walsh wrote:
> > > Unnecessary parentheses in boolean comparisons make it harder to read.
> > > 
> > > Removed the extra parentheses on line 305 for code readability.
> > > 
> > > Signed-off-by: Will Walsh <iron.will.walsh@...il.com>
> > 
> > I'm not sure this makes a big difference in readability but I
> > personally avoid extra parentheses unless adding them makes a
> > compiler warning go away.
> 
> It's not a compiler warning, it checkpatch.

And it is a checkpatch warning that I HATE and keep rejecting, here's
where I did so yesterday:
	https://lore.kernel.org/r/2025010738-gong-rewind-2583@gregkh

Will, sorry, but I don't want to take this.

greg k-h