linux-kernel - Re: [PATCH v3 01/14] btrfs: selftests: correct RAID stripe-tree feature flag setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b4921674-df1f-4c49-9587-25bb810534f2@wdc.com>
Date: Thu, 9 Jan 2025 15:31:05 +0000
From: Johannes Thumshirn <Johannes.Thumshirn@....com>
To: Johannes Thumshirn <jth@...nel.org>, Chris Mason <clm@...com>, Josef Bacik
	<josef@...icpanda.com>, David Sterba <dsterba@...e.com>
CC: Filipe Manana <fdmanana@...e.com>, "linux-btrfs@...r.kernel.org"
	<linux-btrfs@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 01/14] btrfs: selftests: correct RAID stripe-tree
 feature flag setting

On 09.01.25 16:15, Johannes Thumshirn wrote:
> From: Johannes Thumshirn <johannes.thumshirn@....com>
> 
> RAID stripe-tree is an incompatible feature not a read-only compatible, so
> set the incompat flag not a compat_ro one in the selftest code.
> 
> Subsequent changes in btrfs_delete_raid_extent() will start checking for
> this flag.
> 
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@....com>
> ---
>   fs/btrfs/tests/raid-stripe-tree-tests.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/tests/raid-stripe-tree-tests.c b/fs/btrfs/tests/raid-stripe-tree-tests.c
> index 30f17eb7b6a8a1dfa9f66ed5508da42a70db1fa3..2e8083f1d0d184a23317facbb566ef949639a8a7 100644
> --- a/fs/btrfs/tests/raid-stripe-tree-tests.c
> +++ b/fs/btrfs/tests/raid-stripe-tree-tests.c
> @@ -478,7 +478,7 @@ static int run_test(test_func_t test, u32 sectorsize, u32 nodesize)
>   		ret = PTR_ERR(root);
>   		goto out;
>   	}
> -	btrfs_set_super_compat_ro_flags(root->fs_info->super_copy,
> +	btrfs_set_super_incompat_flags(root->fs_info->super_copy,
>   					BTRFS_FEATURE_INCOMPAT_RAID_STRIPE_TREE);

As per the other thread, that needs to be:

+	btrfs_set_fs_incompat(root->fs_info, RAID_STRIPE_TREE);