linux-kernel - Re: [PATCH] i2c: i801: Remove unnecessary PCI function call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3uoxhrghtize4hmp2sofqmi5tpgn5n74zhnvta6743kop2fscz@bk3aza3kostx>
Date: Thu, 9 Jan 2025 16:45:47 +0100
From: Andi Shyti <andi.shyti@...nel.org>
To: Philipp Stanner <pstanner@...hat.com>
Cc: Jean Delvare <jdelvare@...e.com>, linux-i2c@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: i801: Remove unnecessary PCI function call

Hi Philipp,

On Thu, Nov 21, 2024 at 08:56:25PM +0100, Philipp Stanner wrote:
> Since the changes in
> 
> 	commit f748a07a0b64 ("PCI: Remove legacy pcim_release()")
> 
> all pcim_enable_device() does is set up a callback that disables the
> device from being disabled from driver detach. The function
> pcim_pin_device() prevents said disabling. pcim_enable_device(),
> therefore, sets up an action that is removed immediately afterwards by
> pcim_pin_device().
> 
> Replace pcim_enable_device() with pci_enable_device() and remove the
> unnecessary call to pcim_pin_device().
> 
> Signed-off-by: Philipp Stanner <pstanner@...hat.com>

nice cleanup, merged to i2c/i2c-host.

Thanks,
Andi