linux-kernel - Re: [PATCH] treewide: const qualify ctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z3_vF3I453flXoZv@mail.minyard.net>
Date: Thu, 9 Jan 2025 09:45:27 -0600
From: Corey Minyard <corey@...yard.net>
To: Joel Granados <joel.granados@...nel.org>
Cc: Thomas Weißschuh <linux@...ssschuh.net>,
	Kees Cook <kees@...nel.org>, Luis Chamberlain <mcgrof@...nel.org>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org, linux-riscv@...ts.infradead.org,
	linux-s390@...r.kernel.org, linux-crypto@...r.kernel.org,
	openipmi-developer@...ts.sourceforge.net,
	intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
	intel-xe@...ts.freedesktop.org, linux-hyperv@...r.kernel.org,
	linux-rdma@...r.kernel.org, linux-raid@...r.kernel.org,
	linux-scsi@...r.kernel.org, linux-serial@...r.kernel.org,
	xen-devel@...ts.xenproject.org, linux-aio@...ck.org,
	linux-fsdevel@...r.kernel.org, netfs@...ts.linux.dev,
	codalist@...a.cs.cmu.edu, linux-mm@...ck.org,
	linux-nfs@...r.kernel.org, ocfs2-devel@...ts.linux.dev,
	fsverity@...ts.linux.dev, linux-xfs@...r.kernel.org,
	io-uring@...r.kernel.org, bpf@...r.kernel.org,
	kexec@...ts.infradead.org, linux-trace-kernel@...r.kernel.org,
	linux-hardening@...r.kernel.org, apparmor@...ts.ubuntu.com,
	linux-security-module@...r.kernel.org, keyrings@...r.kernel.org
Subject: Re: [PATCH] treewide: const qualify ctl_tables where applicable

On Thu, Jan 09, 2025 at 02:16:39PM +0100, Joel Granados wrote:
> Add the const qualifier to all the ctl_tables in the tree except the
> ones in ./net dir. The "net" sysctl code is special as it modifies the
> arrays before passing it on to the registration function.
> 
...
> diff --git a/drivers/char/ipmi/ipmi_poweroff.c b/drivers/char/ipmi/ipmi_poweroff.c
> index 941d2dcc8c9d..de84f59468a9 100644
> --- a/drivers/char/ipmi/ipmi_poweroff.c
> +++ b/drivers/char/ipmi/ipmi_poweroff.c
> @@ -650,7 +650,7 @@ static struct ipmi_smi_watcher smi_watcher = {
>  #ifdef CONFIG_PROC_FS
>  #include <linux/sysctl.h>
>  
> -static struct ctl_table ipmi_table[] = {
> +static const struct ctl_table ipmi_table[] = {
>  	{ .procname	= "poweroff_powercycle",
>  	  .data		= &poweroff_powercycle,
>  	  .maxlen	= sizeof(poweroff_powercycle),

For the IPMI portion:

Acked-by: Corey Minyard <cminyard@...sta.com>