linux-kernel - RE: [PATCH v3] wifi: rtw89: Correct immediate cfg_len calculation for scan_offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8aded74b33d1471fa822a2c599545775@realtek.com>
Date: Thu, 9 Jan 2025 02:35:12 +0000
From: Ping-Ke Shih <pkshih@...ltek.com>
To: Liang Jie <buaajxlj@....com>
CC: "kvalo@...nel.org" <kvalo@...nel.org>, Bernie Huang <phhuang@...ltek.com>,
        "fanggeng@...iang.com" <fanggeng@...iang.com>,
        "yangchen11@...iang.com"
	<yangchen11@...iang.com>,
        "linux-wireless@...r.kernel.org"
	<linux-wireless@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        Liang Jie <liangjie@...iang.com>
Subject: RE: [PATCH v3] wifi: rtw89: Correct immediate cfg_len calculation for scan_offload_be

Liang Jie <buaajxlj@....com> wrote:
> From: Liang Jie <liangjie@...iang.com>
> 
> Ensures the correct calculation of `cfg_len` prior to the allocation of
> the skb in the `rtw89_fw_h2c_scan_offload_be` function, particularly when
> the `SCAN_OFFLOAD_BE_V0` firmware feature is enabled. It addresses an
> issue where an incorrect skb size might be allocated due to a delayed
> setting of `cfg_len`, potentially leading to memory inefficiencies.
> 
> By moving the conditional check and assignment of `cfg_len` before skb
> allocation, the patch guarantees that `len`, which depends on `cfg_len`,
> is accurately computed, ensuring proper skb size and preventing any
> unnecessary memory reservation for firmware operations not supporting
> beyond the `w8` member of the command data structure.
> 
> This correction helps to optimize memory usage and maintain consistent
> behavior across different firmware versions.
> 
> Fixes: 6ca6b918f280 ("wifi: rtw89: 8922a: Add new fields for scan offload H2C command")
> Signed-off-by: Liang Jie <liangjie@...iang.com>

Acked-by: Ping-Ke Shih <pkshih@...ltek.com>