linux-kernel - Re: [PATCH v3] wifi: rtw89: Correct immediate cfg_len calculation for scan_offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <61e0a972-75d3-4acb-ba73-fcedd1ee4a69@RTEXMBS04.realtek.com.tw>
Date: Sun, 12 Jan 2025 09:50:34 +0800
From: Ping-Ke Shih <pkshih@...ltek.com>
To: Liang Jie <buaajxlj@....com>, <pkshih@...ltek.com>
CC: <kvalo@...nel.org>, <phhuang@...ltek.com>, <fanggeng@...iang.com>,
        <yangchen11@...iang.com>, <linux-wireless@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Liang Jie <liangjie@...iang.com>
Subject: Re: [PATCH v3] wifi: rtw89: Correct immediate cfg_len calculation for scan_offload_be

Liang Jie <buaajxlj@....com> wrote:

> From: Liang Jie <liangjie@...iang.com>
> 
> Ensures the correct calculation of `cfg_len` prior to the allocation of
> the skb in the `rtw89_fw_h2c_scan_offload_be` function, particularly when
> the `SCAN_OFFLOAD_BE_V0` firmware feature is enabled. It addresses an
> issue where an incorrect skb size might be allocated due to a delayed
> setting of `cfg_len`, potentially leading to memory inefficiencies.
> 
> By moving the conditional check and assignment of `cfg_len` before skb
> allocation, the patch guarantees that `len`, which depends on `cfg_len`,
> is accurately computed, ensuring proper skb size and preventing any
> unnecessary memory reservation for firmware operations not supporting
> beyond the `w8` member of the command data structure.
> 
> This correction helps to optimize memory usage and maintain consistent
> behavior across different firmware versions.
> 
> Fixes: 6ca6b918f280 ("wifi: rtw89: 8922a: Add new fields for scan offload H2C command")
> Signed-off-by: Liang Jie <liangjie@...iang.com>
> Acked-by: Ping-Ke Shih <pkshih@...ltek.com>

Failed to apply patch:

  Applying: wifi: rtw89: Correct immediate cfg_len calculation for scan_offload_be
  error: patch failed: drivers/net/wireless/realtek/rtw89/fw.c:5171
  error: drivers/net/wireless/realtek/rtw89/fw.c: patch does not apply
  Patch failed at 0001 wifi: rtw89: Correct immediate cfg_len calculation for scan_offload_be

Please rebase on the top of rtw tree.

Set patchset state to Changes Requested

[v3] wifi: rtw89: Correct immediate cfg_len calculation for scan_offload_be

---
https://github.com/pkshih/rtw.git