linux-kernel - Re: [PATCH] net/ncsi: fix locking in Get MAC Address handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250109083311.20f5f802@kernel.org>
Date: Thu, 9 Jan 2025 08:33:11 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Potin Lai <potin.lai@...ntatw.com>
Cc: Paul Fertser <fercerpav@...il.com>, Samuel Mendoza-Jonas
 <sam@...dozajonas.com>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon
 Horman <horms@...nel.org>, Ivan Mikhaylov <fr0st61te@...il.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org
Subject: Re: [PATCH] net/ncsi: fix locking in Get MAC Address handling

On Thu,  9 Jan 2025 17:50:54 +0300 Paul Fertser wrote:
> Obtaining RTNL lock in a response handler is not allowed since it runs
> in an atomic softirq context. Postpone setting the MAC address by adding
> a dedicated step to the configuration FSM.
> 
> Fixes: 790071347a0a ("net/ncsi: change from ndo_set_mac_address to dev_set_mac_address")
> Cc: stable@...r.kernel.org
> Cc: Potin Lai <potin.lai@...ntatw.com>

Neat!

Potin, please give this a test ASAP.