linux-kernel - Re: [PATCH net-next v2 11/15] net: pse-pd: Add support for PSE device index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250109174942.391cbe6a@kmaincent-XPS-13-7390>
Date: Thu, 9 Jan 2025 17:49:42 +0100
From: Kory Maincent <kory.maincent@...tlin.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: Jakub Kicinski <kuba@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
 <horms@...nel.org>, Donald Hunter <donald.hunter@...il.com>, Jonathan
 Corbet <corbet@....net>, Liam Girdwood <lgirdwood@...il.com>, Mark Brown
 <broonie@...nel.org>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
 linux-doc@...r.kernel.org, Kyle Swenson <kyle.swenson@....tech>, Dent
 Project <dentproject@...uxfoundation.org>, kernel@...gutronix.de, Maxime
 Chevallier <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH net-next v2 11/15] net: pse-pd: Add support for PSE
 device index

On Thu, 9 Jan 2025 17:27:03 +0100
Oleksij Rempel <o.rempel@...gutronix.de> wrote:

> On Thu, Jan 09, 2025 at 05:09:57PM +0100, Kory Maincent wrote:
> > On Thu, 9 Jan 2025 07:59:26 -0800
> > Jakub Kicinski <kuba@...nel.org> wrote:
> >   
> > > On Thu, 09 Jan 2025 11:18:05 +0100 Kory Maincent wrote:  
>  [...]  
> > > 
> > > This index is not used in the series, I see later on you'll add power
> > > evaluation strategy but that also seems to be within a domain not
> > > device?
> > > 
> > > Doesn't it make sense to move patches 11-14 to the next series?
> > > The other 11 patches seem to my untrained eye to reshuffle existing
> > > stuff, so they would make sense as a cohesive series. 

I think I should only drop patch 11 and 12 from this series which add something
new while the rest is reshuffle or fix code.

> > Indeed PSE index is used only as user information but there is nothing
> > correlated. You are right maybe we can add PSE index when we have something
> > usable for it.  
> 
> No user, means, it is not exposed to the user space, it is not about
> actual user space users.

I may have understood incorrectly but still. Not sure the PSE device index is
interesting for now even in the budget evaluation strategy series. It is
related to PSE power domains therefore PSE power domain index solely should be
sufficient.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com