linux-kernel - Re: [PATCH v2] regmap: add cache validity to REGCACHE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <25a56461-88f6-4885-82c0-364b8d1d8e83@sirena.org.uk>
Date: Thu, 9 Jan 2025 16:48:50 +0000
From: Mark Brown <broonie@...nel.org>
To: Sander Vanheule <sander@...nheule.net>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] regmap: add cache validity to REGCACHE_FLAT

On Thu, Jan 09, 2025 at 04:11:05PM +0100, Sander Vanheule wrote:

> +static int regcache_flat_drop(struct regmap *map, unsigned int min,
> +			      unsigned int max)
> +{
> +	struct regcache_flat_data *cache = map->cache;
> +	unsigned int bitmap_min = regcache_flat_get_index(map, min);
> +	unsigned int bitmap_max = regcache_flat_get_index(map, max);
> +
> +	bitmap_clear(cache->valid, index_min, bitmap_max + 1 - bitmap_min);

This doesn't build:

/build/stage/linux/drivers/base/regmap/regcache-flat.c: In function ‘regcache_flat_drop’:
/build/stage/linux/drivers/base/regmap/regcache-flat.c:120:36: error: ‘index_min’ undeclared (first use in this function)
  120 |         bitmap_clear(cache->valid, index_min, bitmap_max + 1 - bitmap_min);
      |                                    ^~~~~~~~~
/build/stage/linux/drivers/base/regmap/regcache-flat.c:120:36: note: each undeclared identifier is reported only once for each function it appears in

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)