linux-kernel - Re: [PATCH v2] regmap: add cache validity to REGCACHE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8954ed9d37a3e8a4e44471ceb5f2c262f4fdcc38.camel@svanheule.net>
Date: Thu, 09 Jan 2025 19:04:32 +0100
From: Sander Vanheule <sander@...nheule.net>
To: Mark Brown <broonie@...nel.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Rafael J. Wysocki"
	 <rafael@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] regmap: add cache validity to REGCACHE_FLAT

Hi Mark,

On Thu, 2025-01-09 at 16:48 +0000, Mark Brown wrote:
> On Thu, Jan 09, 2025 at 04:11:05PM +0100, Sander Vanheule wrote:
> 
> > +static int regcache_flat_drop(struct regmap *map, unsigned int min,
> > +			      unsigned int max)
> > +{
> > +	struct regcache_flat_data *cache = map->cache;
> > +	unsigned int bitmap_min = regcache_flat_get_index(map, min);
> > +	unsigned int bitmap_max = regcache_flat_get_index(map, max);
> > +
> > +	bitmap_clear(cache->valid, index_min, bitmap_max + 1 - bitmap_min);
> 
> This doesn't build:
> 
> /build/stage/linux/drivers/base/regmap/regcache-flat.c: In function
> ‘regcache_flat_drop’:
> /build/stage/linux/drivers/base/regmap/regcache-flat.c:120:36: error: ‘index_min’
> undeclared (first use in this function)
>   120 |         bitmap_clear(cache->valid, index_min, bitmap_max + 1 - bitmap_min);
>       |                                    ^~~~~~~~~
> /build/stage/linux/drivers/base/regmap/regcache-flat.c:120:36: note: each undeclared
> identifier is reported only once for each function it appears in


My apologies., I should have been paying more attention. I've sent a v3 that fixes this.

Best,
Sander