linux-kernel - Re: [PATCH] staging: rtl8723bs: Remove ioctl interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <aeadd5b3-c187-4800-ac1f-fe2b53bfb3f7@app.fastmail.com>
Date: Thu, 09 Jan 2025 22:19:40 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: Yeking@...54.com, linux-staging@...ts.linux.dev
Cc: "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
 "Philipp Hortmann" <philipp.g.hortmann@...il.com>,
 "Masahiro Yamada" <masahiroy@...nel.org>,
 "Nicolas Schier" <nicolas@...sle.eu>, "Hans de Goede" <hdegoede@...hat.com>,
 "Rodrigo Gobbi" <rodrigo.gobbi.7@...il.com>,
 "Dan Carpenter" <dan.carpenter@...aro.org>,
 "Justin Stitt" <justinstitt@...gle.com>,
 "Johannes Berg" <johannes.berg@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: Remove ioctl interface

On Thu, Jan 9, 2025, at 14:20, Yeking@...54.com wrote:
> From: 谢致邦 (XIE Zhibang) <Yeking@...54.com>
>
> Wireless drivers should not use the ioctl interface, so remove this
> interface for the rtl8723bs driver. (found by code inspection)
>
> Fixes: 8bfb36766064 ("wireless: wext: remove ndo_do_ioctl fallback")
> Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver")
> Signed-off-by: 谢致邦 (XIE Zhibang) <Yeking@...54.com>
> ---
>  drivers/staging/rtl8723bs/Makefile            |    1 -
>  .../staging/rtl8723bs/include/osdep_intf.h    |    2 -
>  .../staging/rtl8723bs/os_dep/ioctl_linux.c    | 1286 -----------------
>  drivers/staging/rtl8723bs/os_dep/os_intfs.c   |    1 -
>  4 files changed, 1290 deletions(-)
>  delete mode 100644 drivers/staging/rtl8723bs/os_dep/ioctl_linux.c


Thanks for picking this up again. I had done a complete removal
of ndo_do_ioctl a while ago but hadn't gotten around to finishing
the upstreaming. For my older patches, see
https://lore.kernel.org/all/20231009141908.1767241-7-arnd@kernel.org/

Your version is very similar but seems to miss a couple of stale
data structure and function declarations. Can you make sure you
include all those?

       Arnd