[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <tencent_202D558F9075C15FCD33573BC88F48E03706@qq.com>
Date: Fri, 10 Jan 2025 13:10:23 +0000
From: Yeking@...54.com
To: arnd@...db.de
Cc: Yeking@...54.com,
dan.carpenter@...aro.org,
gregkh@...uxfoundation.org,
hdegoede@...hat.com,
johannes.berg@...el.com,
justinstitt@...gle.com,
linux-kernel@...r.kernel.org,
linux-staging@...ts.linux.dev,
masahiroy@...nel.org,
nicolas@...sle.eu,
philipp.g.hortmann@...il.com,
rodrigo.gobbi.7@...il.com
Subject: Re: Re: [PATCH] staging: rtl8723bs: Remove ioctl interface
> Thanks for picking this up again. I had done a complete removal
> of ndo_do_ioctl a while ago but hadn't gotten around to finishing
> the upstreaming. For my older patches, see
> https://lore.kernel.org/all/20231009141908.1767241-7-arnd@kernel.org/
>
> Your version is very similar but seems to miss a couple of stale
> data structure and function declarations. Can you make sure you
> include all those?
>
> Arnd
Thanks for letting me know that you have an old patch. The stale functions like
rtw_ndev_notifier_call, rtw_ndev_notifier_register and
rtw_ndev_notifier_unregister, and the related struct rtw_ndev_notifier have
been removed in 037f9a6df3fb (staging: rtl8723bs: Remove no-op
netdevice_notifier(), 2024-10-24). As for the intf_priv struct that was removed
in your old patch, it has not been processed yet, because rtl8723bs has a lot
of such structs that have not been used since they were introduced in
554c0a3abf21 (staging: Add rtl8723bs sdio wifi driver, 2017-03-29), such as
many in rtw_mp.h. I plan to deal with these contents later.
XIE Zhibang
Powered by blists - more mailing lists