linux-kernel - Re: [PATCH] ASoC: simple-card: Drop unnecessary "dai-tdm-slot-width-map" property presence check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87h667wqf0.wl-kuninori.morimoto.gx@renesas.com>
Date: Thu, 9 Jan 2025 22:52:57 +0000
From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Mark Brown <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: simple-card: Drop unnecessary "dai-tdm-slot-width-map" property presence check


Hi

> It doesn't matter whether "dai-tdm-slot-width-map" is not present or
> there is some other issue parsing it in of_property_count_elems_of_size()
> causing an error. Drop the presence check and rely on
> of_property_count_elems_of_size() error return if not present.
> 
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>


> diff --git a/sound/soc/generic/simple-card-utils.c b/sound/soc/generic/simple-card-utils.c
> index 91325286894e..e25b387a9776 100644
> --- a/sound/soc/generic/simple-card-utils.c
> +++ b/sound/soc/generic/simple-card-utils.c
> @@ -139,10 +139,9 @@ int simple_util_parse_tdm_width_map(struct device *dev, struct device_node *np,
>  	int n, i, ret;
>  	u32 *p;
>  
> -	if (!of_property_read_bool(np, "dai-tdm-slot-width-map"))
> -		return 0;
> -
>  	n = of_property_count_elems_of_size(np, "dai-tdm-slot-width-map", sizeof(u32));
> +	if (n <= 0)
> +		return 0;
>  	if (n % 3) {
>  		dev_err(dev, "Invalid number of cells for dai-tdm-slot-width-map\n");
>  		return -EINVAL;
> -- 
> 2.45.2
>