lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20250110085752.7a9df6da26c6e63eeb890faf@kernel.org>
Date: Fri, 10 Jan 2025 08:57:52 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Peter Zijlstra <peterz@...radead.org>, Anil S Keshavamurthy
 <anil.s.keshavamurthy@...el.com>, "David S . Miller" <davem@...emloft.net>,
 Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, Oleg Nesterov
 <oleg@...hat.com>, Tzvetomir Stoyanov <tz.stoyanov@...il.com>, Naveen N Rao
 <naveen@...nel.org>, Josh Poimboeuf <jpoimboe@...nel.org>, Jason Baron
 <jbaron@...mai.com>, Ard Biesheuvel <ardb@...nel.org>,
 linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH v6 5/5] tracing: Adopt __free() and guard() for
 trace_fprobe.c

On Thu, 9 Jan 2025 09:56:07 -0500
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Thu,  9 Jan 2025 23:30:22 +0900
> "Masami Hiramatsu (Google)" <mhiramat@...nel.org> wrote:
> 
> > From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> > 
> > Adopt __free() and guard() for trace_fprobe.c to remove gotos.
> > 
> > Signed-off-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> > ---
> >  Changes in v6:
> >   - Rename trace_fprobe_create* functions.
> >   - Rename __free label for trace_fprobe.
> >   - Simplify the last part of trace_fprobe_create_internal().
> > ---
> >  kernel/trace/trace_fprobe.c |  130 ++++++++++++++++++++-----------------------
> >  1 file changed, 61 insertions(+), 69 deletions(-)
> 
> Reviewed-by: Steven Rostedt (Google) <rostedt@...dmis.org>

Thanks for review (and commented!)

> 
> -- Steve


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ