linux-kernel - RE: [PATCH v2] wifi: rtw89: Correct immediate cfg_len calculation for scan_offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250109021148.1114317-1-buaajxlj@163.com>
Date: Thu,  9 Jan 2025 10:11:48 +0800
From: Liang Jie <buaajxlj@....com>
To: pkshih@...ltek.com
Cc: buaajxlj@....com,
	fanggeng@...iang.com,
	kvalo@...nel.org,
	liangjie@...iang.com,
	linux-kernel@...r.kernel.org,
	linux-wireless@...r.kernel.org,
	phhuang@...ltek.com,
	yangchen11@...iang.com
Subject: RE: [PATCH v2] wifi: rtw89: Correct immediate cfg_len calculation for scan_offload_be

On Thu, 9 Jan 2025 01:55:23 +0000, Ping-Ke Shih <pkshih@...ltek.com> wrote:
> Liang Jie <buaajxlj@....com> wrote: 
> > diff --git a/drivers/net/wireless/realtek/rtw89/fw.c b/drivers/net/wireless/realtek/rtw89/fw.c
> > index 2191c037d72e..2be1bee724ca 100644
> > --- a/drivers/net/wireless/realtek/rtw89/fw.c
> > +++ b/drivers/net/wireless/realtek/rtw89/fw.c
> > @@ -5170,6 +5170,7 @@ int rtw89_fw_h2c_scan_offload_be(struct rtw89_dev *rtwdev,
> >         u8 opch_size = sizeof(*opch) * option->num_opch;
> >         u8 probe_id[NUM_NL80211_BANDS];
> >         u8 cfg_len = sizeof(*h2c);
> > +       u8 ver = U8_MAX;
> >         unsigned int cond;
> >         void *ptr;
> >         int ret;
> 
> In reverse X'mas tree. Otherwise, looks good to me. 

Thank you for pointing out the "In reverse X'mas tree" issue in the code structure.
I will address this and submit [PATCH v3] with the necessary corrections.

Best regards,
Liang Jie