linux-kernel - Re: [PATCH 1/3] HID: steelseries: add SteelSeries Arctis 9 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <73e15575fba6cb1093b1b8298e29e9a52ed5930f.camel@hadess.net>
Date: Thu, 09 Jan 2025 14:35:54 +0100
From: Bastien Nocera <hadess@...ess.net>
To: Christian Mayer <christian@...er-bgk.de>, Christian Mayer
 <git@...er-bgk.de>, 	linux-input@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, Jiri Kosina <jikos@...nel.org>, Benjamin
 Tissoires <benjamin.tissoires@...hat.com>
Subject: Re: [PATCH 1/3] HID: steelseries: add SteelSeries Arctis 9 support

On Sun, 2025-01-05 at 11:16 +0100, Christian Mayer wrote:
> 
> > On Wed, 2025-01-01 at 15:11 +0000, Christian Mayer wrote:
<snip>
> >   
> > > +	if (sd->quirks & STEELSERIES_ARCTIS_9) {
> > > +		ret = hid_hw_open(hdev);
> > 
> > Is this needed? If so, this probably needs to be added as a
> > separate
> > commit, for all headsets rather than just this one.
> Yes that's mandatory to get raw_events from the device.
> I thought about adding this to all headsets, but i was not sure if
> this 
> breaks anything for the Arctis 1 headset.
> 
> But i can add this for all headsets, that's fine with me.
> Would you like me to create a completely separate patch for this or 
> should i submit this with the preparation patch which refactors 
> steelseries_headset_fetch_battery?

Please send a patch that does it for both headsets, and I'll test it
locally.