linux-kernel - Re: [PATCH 1/3] HID: steelseries: add SteelSeries Arctis 9 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a0532dd6-9d62-4b96-969e-42cf79b13981@mayer-bgk.de>
Date: Sun, 12 Jan 2025 12:49:17 +0100
From: Christian Mayer <christian@...er-bgk.de>
To: Bastien Nocera <hadess@...ess.net>, Christian Mayer <git@...er-bgk.de>,
 linux-input@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, Jiri Kosina <jikos@...nel.org>,
 Benjamin Tissoires <benjamin.tissoires@...hat.com>
Subject: Re: [PATCH 1/3] HID: steelseries: add SteelSeries Arctis 9 support



Am 09.01.25 um 14:35 schrieb Bastien Nocera:
> On Sun, 2025-01-05 at 11:16 +0100, Christian Mayer wrote:
>>
>>> On Wed, 2025-01-01 at 15:11 +0000, Christian Mayer wrote:
> <snip>
>>>    
>>>> +	if (sd->quirks & STEELSERIES_ARCTIS_9) {
>>>> +		ret = hid_hw_open(hdev);
>>>
>>> Is this needed? If so, this probably needs to be added as a
>>> separate
>>> commit, for all headsets rather than just this one.
>> Yes that's mandatory to get raw_events from the device.
>> I thought about adding this to all headsets, but i was not sure if
>> this
>> breaks anything for the Arctis 1 headset.
>>
>> But i can add this for all headsets, that's fine with me.
>> Would you like me to create a completely separate patch for this or
>> should i submit this with the preparation patch which refactors
>> steelseries_headset_fetch_battery?
> 
> Please send a patch that does it for both headsets, and I'll test it
> locally.
I resent the patches with the requested changes (v2)
Please use 
v2-0001-HID-steelseries-preparation-for-adding-SteelSerie.patch for testing.