linux-kernel - Re: [PATCH] HID: lenovo: Fix undefined platform_profile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <p6s4s47q-15ss-ps35-6387-n2nsqn05o335@xreary.bet>
Date: Fri, 10 Jan 2025 16:05:17 +0100 (CET)
From: Jiri Kosina <jikos@...nel.org>
To: Vishnu Sankar <vishnuocv@...il.com>
cc: bentiss@...nel.org, linux-input@...r.kernel.org, 
    linux-kernel@...r.kernel.org, mpearson-lenovo@...ebb.ca, 
    vsankar@...ovo.com
Subject: Re: [PATCH] HID: lenovo: Fix undefined platform_profile_cycle in
 ThinkPad X12 keyboard patch

On Fri, 10 Jan 2025, Vishnu Sankar wrote:

> The commit "HID: lenovo: Support for ThinkPad-X12-TAB-1/2 Kbd Fn keys"
> introduced an issue where the CI failed with the following error:
> ERROR: modpost: "platform_profile_cycle" [drivers/hid/hid-lenovo.ko] undefined!
> 
> This issue occurs because platform_profile_cycle is used without ensuring
> the kernel is configured with CONFIG_ACPI_PLATFORM_PROFILE.
> To address this, this patch adds conditional support for platform profile
> management to the Fn+F8 key handling.
> The functionality for platform_profile_cycle is now included only when
> CONFIG_ACPI_PLATFORM_PROFILE is enabled in the kernel configuration.
> 
> This ensures compatibility with kernels that do not include the ACPI
> platform profile feature, resolving the CI build issue.

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs