linux-kernel - Re: [PATCH] HID: lenovo: Fix undefined platform_profile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABxCQKsOG12rp0ysDESNJEXa2AewLusHFTmtj--FNN-ucVgO=g@mail.gmail.com>
Date: Mon, 13 Jan 2025 20:30:43 +0900
From: Vishnu Sankar <vishnuocv@...il.com>
To: Jiri Kosina <jikos@...nel.org>
Cc: bentiss@...nel.org, linux-input@...r.kernel.org, 
	linux-kernel@...r.kernel.org, mpearson-lenovo@...ebb.ca, vsankar@...ovo.com
Subject: Re: [PATCH] HID: lenovo: Fix undefined platform_profile_cycle in
 ThinkPad X12 keyboard patch

Jiri,
Thanks a lot.

On Sat, Jan 11, 2025 at 12:05 AM Jiri Kosina <jikos@...nel.org> wrote:
>
> On Fri, 10 Jan 2025, Vishnu Sankar wrote:
>
> > The commit "HID: lenovo: Support for ThinkPad-X12-TAB-1/2 Kbd Fn keys"
> > introduced an issue where the CI failed with the following error:
> > ERROR: modpost: "platform_profile_cycle" [drivers/hid/hid-lenovo.ko] undefined!
> >
> > This issue occurs because platform_profile_cycle is used without ensuring
> > the kernel is configured with CONFIG_ACPI_PLATFORM_PROFILE.
> > To address this, this patch adds conditional support for platform profile
> > management to the Fn+F8 key handling.
> > The functionality for platform_profile_cycle is now included only when
> > CONFIG_ACPI_PLATFORM_PROFILE is enabled in the kernel configuration.
> >
> > This ensures compatibility with kernels that do not include the ACPI
> > platform profile feature, resolving the CI build issue.
>
> Applied, thanks.
>
> --
> Jiri Kosina
> SUSE Labs
>


-- 

Regards,

      Vishnu Sankar
     +817015150407 (Japan)