linux-kernel - Re: [PATCH net-next v2 06/14] net: ethernet: qualcomm: Initialize the PPE scheduler settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <caf8bc02-ef31-4426-a362-06d97d4626fd@quicinc.com>
Date: Fri, 10 Jan 2025 23:40:14 +0800
From: Jie Luo <quic_luoj@...cinc.com>
To: Simon Horman <horms@...nel.org>
CC: Andrew Lunn <andrew+netdev@...n.ch>,
        "David S. Miller"
	<davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Rob Herring
	<robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
	<conor+dt@...nel.org>, Lei Wei <quic_leiwei@...cinc.com>,
        Suruchi Agarwal
	<quic_suruchia@...cinc.com>,
        Pavithra R <quic_pavir@...cinc.com>,
        "Jonathan
 Corbet" <corbet@....net>, Kees Cook <kees@...nel.org>,
        "Gustavo A. R. Silva"
	<gustavoars@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        <linux-arm-msm@...r.kernel.org>, <netdev@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-doc@...r.kernel.org>, <linux-hardening@...r.kernel.org>,
        <quic_kkumarcs@...cinc.com>, <quic_linchen@...cinc.com>,
        <srinivas.kandagatla@...aro.org>, <bartosz.golaszewski@...aro.org>,
        <john@...ozen.org>
Subject: Re: [PATCH net-next v2 06/14] net: ethernet: qualcomm: Initialize the
 PPE scheduler settings



On 1/10/2025 1:42 AM, Simon Horman wrote:
> On Wed, Jan 08, 2025 at 09:47:13PM +0800, Luo Jie wrote:
>> The PPE scheduler settings determine the priority of scheduling the
>> packet across the different hardware queues per PPE port.
>>
>> Signed-off-by: Luo Jie <quic_luoj@...cinc.com>
>> ---
>>   drivers/net/ethernet/qualcomm/ppe/ppe_config.c | 789 ++++++++++++++++++++++++-
>>   drivers/net/ethernet/qualcomm/ppe/ppe_config.h |  37 ++
>>   drivers/net/ethernet/qualcomm/ppe/ppe_regs.h   |  97 +++
>>   3 files changed, 922 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/qualcomm/ppe/ppe_config.c b/drivers/net/ethernet/qualcomm/ppe/ppe_config.c
> 
> ...
> 
>> +/**
>> + * ppe_queue_scheduler_set - Configure scheduler for PPE hardware queue
>> + * @ppe_dev: PPE device
>> + * @node_id: PPE queue ID or flow ID
>> + * @flow_level: Flow level scheduler or queue level scheduler
>> + * @port: PPE port ID set scheduler configuration
>> + * @scheduler_cfg: PPE scheduler configuration
>> + *
>> + * PPE scheduler configuration supports queue level and flow level on
>> + * the PPE egress port.
>> + *
>> + * Return 0 on success, negative error code on failure.
> 
> Nit: The tooling would prefer this last line formatted as;
> 
>      * Return: ...
> 
> or
> 
>      * Returns: ...
> 
> Flagged by ./scripts/kernel-doc -none -Wall

OK, I will update the kernel-doc comments and run the kernel-doc to
verify proper formatting of the documentation comments on all patches.

> 
>> + */
>> +int ppe_queue_scheduler_set(struct ppe_device *ppe_dev,
>> +			    int node_id, bool flow_level, int port,
>> +			    struct ppe_scheduler_cfg scheduler_cfg)
>> +{
>> +	if (flow_level)
>> +		return ppe_scheduler_l1_queue_map_set(ppe_dev, node_id,
>> +						      port, scheduler_cfg);
>> +
>> +	return ppe_scheduler_l0_queue_map_set(ppe_dev, node_id,
>> +					      port, scheduler_cfg);
>> +}
> 
> ...