linux-kernel - Re: [PATCH 3/4] kconfig: qconf: remove overloaded constructor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNAQq29ws6+vNUzqfUr867q8h4EbWzx6SQgHB0YzaZ2LcEw@mail.gmail.com>
Date: Sat, 11 Jan 2025 02:29:06 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Rolf Eike Beer <eb@...ix.com>
Cc: linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] kconfig: qconf: remove overloaded constructor

On Thu, Dec 19, 2024 at 4:23 PM Rolf Eike Beer <eb@...ix.com> wrote:
>
> No extra implementation is needed for this variant, provide a default argument
> to the matching sibling instead.


I am not sure if this is equivalent conversion
because you are changing goParent(true)
into goParent(false).




> Signed-off-by: Rolf Eike Beer <eb@...ix.com>
> ---
>  scripts/kconfig/qconf.h | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/scripts/kconfig/qconf.h b/scripts/kconfig/qconf.h
> index 62ab3286d04f..1c90fec4c2da 100644
> --- a/scripts/kconfig/qconf.h
> +++ b/scripts/kconfig/qconf.h
> @@ -114,7 +114,7 @@ public slots:
>  class ConfigItem : public QTreeWidgetItem {
>         typedef class QTreeWidgetItem Parent;
>  public:
> -       ConfigItem(ConfigList *parent, ConfigItem *after, struct menu *m)
> +       ConfigItem(ConfigList *parent, ConfigItem *after, struct menu *m = nullptr)
>         : Parent(parent, after), nextItem(0), menu(m), goParent(false)
>         {
>                 init();
> @@ -124,11 +124,6 @@ class ConfigItem : public QTreeWidgetItem {
>         {
>                 init();
>         }
> -       ConfigItem(ConfigList *parent, ConfigItem *after)
> -       : Parent(parent, after), nextItem(0), menu(0), goParent(true)
> -       {
> -               init();
> -       }
>         ~ConfigItem(void);
>         void init(void);
>         void updateMenu(void);
> --
> 2.47.1
>
>
> --
> Rolf Eike Beer
>
> emlix GmbH
> Headquarters: Berliner Str. 12, 37073 Göttingen, Germany
> Phone +49 (0)551 30664-0, e-mail info@...ix.com
> District Court of Göttingen, Registry Number HR B 3160
> Managing Directors: Heike Jordan, Dr. Uwe Kracke
> VAT ID No. DE 205 198 055
> Office Berlin: Panoramastr. 1, 10178 Berlin, Germany
> Office Bonn: Bachstr. 6, 53115 Bonn, Germany
> http://www.emlix.com
>
> emlix - your embedded Linux partner
>
>


-- 
Best Regards
Masahiro Yamada