linux-kernel - Re: [PATCH 3/4] kconfig: qconf: remove overloaded constructor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <13679214.uLZWGnKmhe@devpool47.emlix.com>
Date: Tue, 14 Jan 2025 14:03:57 +0100
From: Rolf Eike Beer <eb@...ix.com>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] kconfig: qconf: remove overloaded constructor

On Freitag, 10. Januar 2025 18:29:06 Mitteleuropäische Normalzeit Masahiro 
Yamada wrote:
> On Thu, Dec 19, 2024 at 4:23 PM Rolf Eike Beer <eb@...ix.com> wrote:
> > No extra implementation is needed for this variant, provide a default
> > argument to the matching sibling instead.
> 
> I am not sure if this is equivalent conversion
> because you are changing goParent(true)
> into goParent(false).

It is not, for exactly that reason. Found that out the hard way, i.e. it 
crashes in some situations which I didn't notice before. I'll send an updated 
patch.

Regards,

Eike
-- 
Rolf Eike Beer

emlix GmbH
Headquarters: Berliner Str. 12, 37073 Göttingen, Germany
Phone +49 (0)551 30664-0, e-mail info@...ix.com
District Court of Göttingen, Registry Number HR B 3160
Managing Directors: Heike Jordan, Dr. Uwe Kracke
VAT ID No. DE 205 198 055
Office Berlin: Panoramastr. 1, 10178 Berlin, Germany
Office Bonn: Bachstr. 6, 53115 Bonn, Germany
http://www.emlix.com

emlix - your embedded Linux partner
Download attachment "signature.asc" of type "application/pgp-signature" (314 bytes)