linux-kernel - Re: [RESEND PATCH] MIPS: ftrace: Declare ftrace_get_parent_ra

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d4d4c1f6-84d8-4168-991e-dbd36091d520@linaro.org>
Date: Fri, 10 Jan 2025 09:13:35 +0100
From: Philippe Mathieu-Daudé <philmd@...aro.org>
To: WangYuli <wangyuli@...ontech.com>, rostedt@...dmis.org,
 mhiramat@...nel.org, mark.rutland@....com, tsbogend@...ha.franken.de
Cc: linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 linux-mips@...r.kernel.org, xzhong86@....com, wuzhangjin@...il.com,
 srostedt@...hat.com, linux-mips@...ux-mips.org, ralf@...k.linux-mips.net,
 jeffbai@...c.io, zhanjun@...ontech.com, guanwentao@...ontech.com,
 jiaxun.yang@...goat.com, gregory.clement@...tlin.com, tglx@...utronix.de,
 rppt@...nel.org
Subject: Re: [RESEND PATCH] MIPS: ftrace: Declare ftrace_get_parent_ra_addr()
 as static

On 4/1/25 15:47, WangYuli wrote:
> Declare ftrace_get_parent_ra_addr() as static to suppress clang
> compiler warning that 'no previous prototype'. This function is
> not intended to be called from other parts.

Since 2009 in commit 29c5d3462f7c ("MIPS: Tracing: Add function
graph tracer support for MIPS") eh :)

> 
> Fix follow error with clang-19:
> 
> arch/mips/kernel/ftrace.c:251:15: error: no previous prototype for function 'ftrace_get_parent_ra_addr' [-Werror,-Wmissing-prototypes]
>    251 | unsigned long ftrace_get_parent_ra_addr(unsigned long self_ra, unsigned long
>        |               ^
> arch/mips/kernel/ftrace.c:251:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>    251 | unsigned long ftrace_get_parent_ra_addr(unsigned long self_ra, unsigned long
>        | ^
>        | static
> 1 error generated.
> 
> Signed-off-by: WangYuli <wangyuli@...ontech.com>
> ---
>   arch/mips/kernel/ftrace.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@...aro.org>