linux-kernel - Re: [RESEND PATCH] MIPS: ftrace: Declare ftrace_get_parent_ra

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250106152240.7e2220bc@gandalf.local.home>
Date: Mon, 6 Jan 2025 15:22:40 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@...nel.org>
Cc: WangYuli <wangyuli@...ontech.com>, mark.rutland@....com,
 tsbogend@...ha.franken.de, linux-kernel@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org, linux-mips@...r.kernel.org,
 xzhong86@....com, wuzhangjin@...il.com, srostedt@...hat.com,
 linux-mips@...ux-mips.org, ralf@...k.linux-mips.net, jeffbai@...c.io,
 zhanjun@...ontech.com, guanwentao@...ontech.com, jiaxun.yang@...goat.com,
 gregory.clement@...tlin.com, philmd@...aro.org, tglx@...utronix.de,
 rppt@...nel.org
Subject: Re: [RESEND PATCH] MIPS: ftrace: Declare
 ftrace_get_parent_ra_addr() as static

On Sun, 5 Jan 2025 17:37:47 +0900
Masami Hiramatsu (Google) <mhiramat@...nel.org> wrote:

> On Sat,  4 Jan 2025 22:47:08 +0800
> WangYuli <wangyuli@...ontech.com> wrote:
> 
> > Declare ftrace_get_parent_ra_addr() as static to suppress clang
> > compiler warning that 'no previous prototype'. This function is
> > not intended to be called from other parts.
> > 
> > Fix follow error with clang-19:
> > 
> > arch/mips/kernel/ftrace.c:251:15: error: no previous prototype for function 'ftrace_get_parent_ra_addr' [-Werror,-Wmissing-prototypes]
> >   251 | unsigned long ftrace_get_parent_ra_addr(unsigned long self_ra, unsigned long
> >       |               ^
> > arch/mips/kernel/ftrace.c:251:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> >   251 | unsigned long ftrace_get_parent_ra_addr(unsigned long self_ra, unsigned long
> >       | ^
> >       | static
> > 1 error generated.  
> 
> Looks good to me.
> 
> Acked-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> 

Note, this should go through the MIPS tree.

-- Steve