linux-kernel - Re: [PATCH v2 1/2] dt-bindings: hwmon: ti,ina2xx: Add INA233 device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <pmg3xfdr2tu4yaed5hmi3ttj43gqmgzguckbfonr24o6l33pem@nfuxw3cbkzt2>
Date: Fri, 10 Jan 2025 09:36:51 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Leo Yang <leo.yang.sy0@...il.com>
Cc: jdelvare@...e.com, linux@...ck-us.net, robh@...nel.org, 
	davem@...emloft.net, krzk+dt@...nel.org, conor+dt@...nel.org, Leo-Yang@...ntatw.com, 
	corbet@....net, Delphine_CC_Chiu@...ynn.com, linux-hwmon@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: hwmon: ti,ina2xx: Add INA233 device

On Fri, Jan 10, 2025 at 04:15:45PM +0800, Leo Yang wrote:
> Add TI INA233 Current and Power Monitor bindings.
> 
> Signed-off-by: Leo Yang <Leo-Yang@...ntatw.com>

Also, SoB does not match From.

Please run scripts/checkpatch.pl and fix reported warnings. After that,
run also 'scripts/checkpatch.pl --strict' and (probably) fix more
warnings. Some warnings can be ignored, especially from --strict run,
but the code here looks like it needs a fix. Feel free to get in touch
if the warning is not clear.

Best regards,
Krzysztof