linux-kernel - Re: [PATCH v2 1/3] dt-bindings: clock: Add bindings for Canaan K230 clock controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a5f8fd53-2519-441d-8931-31cb9aa2eba0@zohomail.com>
Date: Fri, 10 Jan 2025 19:28:23 +0800
From: Xukai Wang <kingxukai@...omail.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Michael Turquette <mturquette@...libre.com>,
 Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Paul Walmsley <paul.walmsley@...ive.com>,
 Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
 Troy Mitchell <TroyMitchell988@...il.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: clock: Add bindings for Canaan K230
 clock controller



On 2025/1/9 17:02, Krzysztof Kozlowski wrote:
> On Wed, Jan 08, 2025 at 07:53:07PM +0800, Xukai Wang wrote:
>> +properties:
>> +  compatible:
>> +    const: canaan,k230-clk
>> +
>> +  clocks:
>> +    maxItems: 1
>> +
>> +  reg:
>> +    items:
>> +      - description: PLL control registers.
>> +      - description: Sysclk control registers.
>> +
>> +  '#clock-cells':
>> +    const: 1
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - clocks
> 
> If there is going to be any new version, then keep the same order in
> required: as in properties:
> 
> In any case:
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
Thank you for the review and your suggestions.

I will ensure that the order of `required:` matches the order in 
`properties:` in any future versions of the patch.

> Best regards,
> Krzysztof
>