linux-kernel - Re: [PATCH] serial: 8250_it8768e: Create iTE IT8768E specific 8250 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202501110920.kLUGElwx-lkp@intel.com>
Date: Sat, 11 Jan 2025 09:35:45 +0800
From: kernel test robot <lkp@...el.com>
To: WangYuli <wangyuli@...ontech.com>, gregkh@...uxfoundation.org,
	jirislaby@...nel.org
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org, andriy.shevchenko@...ux.intel.com,
	arnd@...nel.org, schnelle@...ux.ibm.com, pnewman@...necttech.com,
	sunilvl@...tanamicro.com, paulmck@...nel.org, arnd@...db.de,
	zhanjun@...ontech.com, guanwentao@...ontech.com,
	Zhuozhen He <hezhuozhen@...ontech.com>,
	Guowei Chen <chenguowei@...ontech.com>
Subject: Re: [PATCH] serial: 8250_it8768e: Create iTE IT8768E specific 8250
 driver

Hi WangYuli,

kernel test robot noticed the following build warnings:

[auto build test WARNING on tty/tty-testing]
[also build test WARNING on tty/tty-next tty/tty-linus usb/usb-testing usb/usb-next usb/usb-linus linus/master v6.13-rc6 next-20250110]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/WangYuli/serial-8250_it8768e-Create-iTE-IT8768E-specific-8250-driver/20250109-201036
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
patch link:    https://lore.kernel.org/r/41B1320691916DE6%2B20250109120808.559950-1-wangyuli%40uniontech.com
patch subject: [PATCH] serial: 8250_it8768e: Create iTE IT8768E specific 8250 driver
config: i386-randconfig-062-20250111 (https://download.01.org/0day-ci/archive/20250111/202501110920.kLUGElwx-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250111/202501110920.kLUGElwx-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501110920.kLUGElwx-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/tty/serial/8250/8250_it8768e.c:39:18: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected void *[noderef] __iomem sio_base @@     got void [noderef] __iomem * @@
   drivers/tty/serial/8250/8250_it8768e.c:39:18: sparse:     expected void *[noderef] __iomem sio_base
   drivers/tty/serial/8250/8250_it8768e.c:39:18: sparse:     got void [noderef] __iomem *
>> drivers/tty/serial/8250/8250_it8768e.c:58:33: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected unsigned char [noderef] __iomem *membase @@     got void *[noderef] __iomem sio_base @@
   drivers/tty/serial/8250/8250_it8768e.c:58:33: sparse:     expected unsigned char [noderef] __iomem *membase
   drivers/tty/serial/8250/8250_it8768e.c:58:33: sparse:     got void *[noderef] __iomem sio_base
>> drivers/tty/serial/8250/8250_it8768e.c:40:14: sparse: sparse: dereference of noderef expression

vim +39 drivers/tty/serial/8250/8250_it8768e.c

    26	
    27	static int it8768e_probe(struct platform_device *pdev)
    28	{
    29		struct it8768e_data *data;
    30		struct resource *res;
    31		void *__iomem sio_base;
    32	
    33		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
    34		if (!res) {
    35			dev_err(&pdev->dev, "memory resource not found\n");
    36			return -EINVAL;
    37		}
    38	
  > 39		sio_base = devm_ioremap(&pdev->dev, res->start, resource_size(res));
  > 40		if (!sio_base) {
    41			dev_err(&pdev->dev, "devm_ioremap error\n");
    42			return -ENOMEM;
    43		}
    44	
    45		data = devm_kcalloc(&pdev->dev, 1,
    46				sizeof(struct it8768e_data),
    47				GFP_KERNEL);
    48		if (!data) {
    49			dev_err(&pdev->dev, "Failed to alloc private mem struct.\n");
    50			return -ENOMEM;
    51		}
    52	
    53		spin_lock_init(&data->uart.port.lock);
    54		data->uart.port.dev = &pdev->dev;
    55		data->uart.port.regshift = 0;
    56		data->uart.port.iotype = UPIO_MEM;
    57		data->uart.port.type = PORT_16550A;
  > 58		data->uart.port.membase = sio_base;
    59		data->uart.port.mapbase = res->start;
    60		data->uart.port.uartclk = 1843200;
    61		data->uart.port.flags = UPF_FIXED_PORT | UPF_FIXED_TYPE | UPF_SKIP_TEST;
    62	
    63		data->line = serial8250_register_8250_port(&data->uart);
    64		if (data->line < 0) {
    65			dev_err(&pdev->dev,
    66				"unable to resigter 8250 port (MEM%llx): %d\n",
    67				(unsigned long long)res->start, 0);
    68			return data->line;
    69		}
    70	
    71		dev_set_drvdata(&pdev->dev, data);
    72		return 0;
    73	}
    74	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki