linux-kernel - Re: [PATCH] serial: 8250_it8768e: Create iTE IT8768E specific 8250 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z4TkDgYSSm7nwUhY@smile.fi.intel.com>
Date: Mon, 13 Jan 2025 11:59:42 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Arnd Bergmann <arnd@...db.de>
Cc: WangYuli <wangyuli@...ontech.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jirislaby@...nel.org>, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org, Arnd Bergmann <arnd@...nel.org>,
	Niklas Schnelle <schnelle@...ux.ibm.com>, pnewman@...necttech.com,
	Sunil V L <sunilvl@...tanamicro.com>,
	"Paul E. McKenney" <paulmck@...nel.org>, zhanjun@...ontech.com,
	guanwentao@...ontech.com, Zhuozhen He <hezhuozhen@...ontech.com>,
	Guowei Chen <chenguowei@...ontech.com>
Subject: Re: [PATCH] serial: 8250_it8768e: Create iTE IT8768E specific 8250
 driver

On Thu, Jan 09, 2025 at 01:40:14PM +0100, Arnd Bergmann wrote:
> On Thu, Jan 9, 2025, at 13:08, WangYuli wrote:
> > [ General description per its product manual: ]
> >   The IT8768E-I is a highly integrated Super I/O using the Low Pin
> >   Count Interface. The device’s LPC interface complies with Intel
> >   "LPC Interface Specification Rev. 1.1”. The IT8768E-I is ACPI &
> >   LANDesk compliant.
> >
> >   Integrated in the IT8768E-I are five logical devices, which can
> >   be individually enabled or disabled via software configuration
> >   registers, and four 16C550standard compatible enhanced UARTs
> >   perofrmacing asynchronous communication. The devices also provide
> >   GPIO port controlling up to 12 GPIO pins.
> >
> >   The IT8768E-I utilizes power-saving circuitry to reduce power
> >   consumption, and once a logical device is disabled, the inputs
> >   are inhibited with the clock disabled and the outputs are
> >   tri-stated. The device requires a single 24/48 MHz clock input
> >   and operates with +3.3V power supply. The IT8768E-I is available
> >   in 48-pin LQFP.
> >
> > It has been determined that this chip is currently employed within
> > YIHUA STS-320 intelligent teller terminals utilizing
> > PCBA F21-2401 D2000 MB VerA LF motherboards.
> 
> Can you explain why this isn't done as part of
> drivers/tty/serial/8250/8250_pnp.c?

I assume you meant 8250_platform.c. PNP is for devices went through legacy PNP
enumeration, most likely having IOPORT instead of IOMEM.

Recently 8250_platform.c was expanded to cover ACPI IDs and it seems they have
proper ID allocated for their device, so that's where it seems best to fit.

> I see nothing unusual in here that requires a custom driver.

+1.

-- 
With Best Regards,
Andy Shevchenko