linux-kernel - Re: [PATCH] serial: 8250_it8768e: Create iTE IT8768E specific 8250 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <7dd87e6f-6a86-409f-9e1d-4a2d836e399d@app.fastmail.com>
Date: Mon, 13 Jan 2025 11:36:08 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Andy Shevchenko" <andriy.shevchenko@...ux.intel.com>
Cc: WangYuli <wangyuli@...ontech.com>,
 "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
 "Jiri Slaby" <jirislaby@...nel.org>, linux-kernel@...r.kernel.org,
 linux-serial@...r.kernel.org, "Arnd Bergmann" <arnd@...nel.org>,
 "Niklas Schnelle" <schnelle@...ux.ibm.com>, pnewman@...necttech.com,
 "Sunil V L" <sunilvl@...tanamicro.com>,
 "Paul E. McKenney" <paulmck@...nel.org>, zhanjun@...ontech.com,
 guanwentao@...ontech.com, "Zhuozhen He" <hezhuozhen@...ontech.com>,
 "Guowei Chen" <chenguowei@...ontech.com>
Subject: Re: [PATCH] serial: 8250_it8768e: Create iTE IT8768E specific 8250 driver

On Mon, Jan 13, 2025, at 10:59, Andy Shevchenko wrote:
> On Thu, Jan 09, 2025 at 01:40:14PM +0100, Arnd Bergmann wrote:
>> On Thu, Jan 9, 2025, at 13:08, WangYuli wrote:
>> 
>> Can you explain why this isn't done as part of
>> drivers/tty/serial/8250/8250_pnp.c?
>
> I assume you meant 8250_platform.c. PNP is for devices went through legacy PNP
> enumeration, most likely having IOPORT instead of IOMEM.

No, I meant the 8250_pnp.c file.

> Recently 8250_platform.c was expanded to cover ACPI IDs and it seems they have
> proper ID allocated for their device, so that's where it seems best to fit.

I don't think we should expand the use of 8250_platform.c
any more than it is already used for. The ACPI device ID stuff in
there is really only for one specific platform and should probably
get moved out as well, the rest is there for hardwired
"plat_serial8250_port" devices on 25+ year old machines that
predate any type of firmware (pnpbios, acpibios, of) or hardware
(ispnp, pci, ...) autodetection for their uarts.

     Arnd