[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20250110174541.bf22caf1afa227b9a76a7e4c@linux-foundation.org>
Date: Fri, 10 Jan 2025 17:45:41 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: David Hildenbrand <david@...hat.com>
Cc: yangge1116@....com, linux-mm@...ck.org, linux-kernel@...r.kernel.org,
21cnbao@...il.com, baolin.wang@...ux.alibaba.com, liuzixing@...on.cn
Subject: Re: [PATCH] mm/hugetlb: prevent reuse of isolated free hugepages
On Fri, 10 Jan 2025 09:14:47 +0100 David Hildenbrand <david@...hat.com> wrote:
> > To migrate huge 0, we obtain huge x from the pool. After the migration
> > is completed, we return the now-freed huge 0 back to the pool. When
> > it's time to migrate huge 1, we can simply reuse the now-freed huge 0
> > from the pool. As a result, when replace_free_hugepage_folios() is
> > executed, it cannot release huge 0 back to the buddy system.
> >
> > To slove the proble above, we should prevent reuse of isolated free
> > hugepages.
>
> s/slove/solve/
> s/proble/problem/
>
> >
> > Link: https://lore.kernel.org/lkml/1734503588-16254-1-git-send-email-yangge1116@126.com/
> > Fixes: 08d312ee4c0a ("mm: replace free hugepage folios after migration")
>
> The commit id is not stable yet.
>
> $ git tag --contains 08d312ee4c0a
> mm-everything-2025-01-09-06-44
> next-20250110
>
>
> We should squash this into the original fix. Can you resend the whole
> thing and merge the patch descriptions?
I queued this as
replace-free-hugepage-folios-after-migration-fix-3.patch. But yes, a
clean v4 with a redone changelog would be a nice thing to have.
Powered by blists - more mailing lists