linux-kernel - Re: [PATCH] mm/hugetlb: prevent reuse of isolated free hugepages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bba76a37-3bcd-460b-964f-a58c2d49690e@126.com>
Date: Sat, 11 Jan 2025 16:00:59 +0800
From: Ge Yang <yangge1116@....com>
To: Andrew Morton <akpm@...ux-foundation.org>,
 David Hildenbrand <david@...hat.com>
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org, 21cnbao@...il.com,
 baolin.wang@...ux.alibaba.com, liuzixing@...on.cn
Subject: Re: [PATCH] mm/hugetlb: prevent reuse of isolated free hugepages



在 2025/1/11 9:45, Andrew Morton 写道:
> On Fri, 10 Jan 2025 09:14:47 +0100 David Hildenbrand <david@...hat.com> wrote:
> 
>>> To migrate huge 0, we obtain huge x from the pool. After the migration
>>> is completed, we return the now-freed huge 0 back to the pool. When
>>> it's time to migrate huge 1, we can simply reuse the now-freed huge 0
>>> from the pool. As a result, when replace_free_hugepage_folios() is
>>> executed, it cannot release huge 0 back to the buddy system.
>>>
>>> To slove the proble above, we should prevent reuse of isolated free
>>> hugepages.
>>
>> s/slove/solve/
>> s/proble/problem/
>>
>>>
>>> Link: https://lore.kernel.org/lkml/1734503588-16254-1-git-send-email-yangge1116@126.com/
>>> Fixes: 08d312ee4c0a ("mm: replace free hugepage folios after migration")
>>
>> The commit id is not stable yet.
>>
>> $ git tag --contains  08d312ee4c0a
>> mm-everything-2025-01-09-06-44
>> next-20250110
>>
>>
>> We should squash this into the original fix. Can you resend the whole
>> thing and merge the patch descriptions?
> 
> I queued this as
> replace-free-hugepage-folios-after-migration-fix-3.patch.  But yes, a
> clean v4 with a redone changelog would be a nice thing to have.

ok, thanks.