linux-kernel - Re: [PATCH] Add short author date to Fixes tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52541f79-ba1c-49c9-a576-45c3472d1c79@intel.com>
Date: Fri, 10 Jan 2025 16:21:35 -0800
From: Jacob Keller <jacob.e.keller@...el.com>
To: Steven Rostedt <rostedt@...dmis.org>, <Yeking@...54.com>
CC: <kuba@...nel.org>, Jonathan Corbet <corbet@....net>, Theodore Ts'o
	<tytso@....edu>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Andy
 Whitcroft" <apw@...onical.com>, Joe Perches <joe@...ches.com>, Dwaipayan Ray
	<dwaipayanray1@...il.com>, Lukas Bulwahn <lukas.bulwahn@...il.com>, "Andrew
 Morton" <akpm@...ux-foundation.org>, <workflows@...r.kernel.org>,
	<linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<tech-board-discuss@...ts.linux.dev>
Subject: Re: [PATCH] Add short author date to Fixes tag

On 1/10/2025 5:03 AM, Steven Rostedt wrote:
> On Fri, 10 Jan 2025 12:20:09 +0000
> Yeking@...54.com wrote:
> 
>> The old Fixes tag style is at least 10 years old. It lacks date
>> information, which can lead to misjudgment. So I added short author date
>> to avoid this. This make it clear at a glance and reduce
>> misunderstandings.
> 
> How can it lead to misjudgment? If you have two or more hashes matching, do
> you really think they'll have the same subjects?
> 
> I do not plan on doing this. It's pointless.
> 
> -- Steve

While the addition of the date is a widely used variant within the git
community, this was rejected by the kernel community in the past as
well. I remember posting fixes tags with the date several years ago and
getting push back.

I tried to find reference to these discussions but I can't seem to
locate them anymore on the archives.

I personally find the date helpful as it can help place a commit without
needing to take the extra time to do a lookup.

However, all of the existing tooling we have for the kernel does not
support the date, and I think its not worth trying to change it at this
point. It doesn't make sense to break all this tooling for information
which is accessible in other forms. Indeed, as long as the hash is
sufficiently long, the change of a collision is minimal.