linux-kernel - Re: [PATCH] APEI: GHES: Have GHES honor the panic= setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <678572b7c28b0_182bf92941f@iweiny-mobl.notmuch>
Date: Mon, 13 Jan 2025 14:08:23 -0600
From: Ira Weiny <ira.weiny@...el.com>
To: Borislav Petkov <bp@...en8.de>, "Rafael J. Wysocki" <rafael@...nel.org>
CC: "Huang, Ying" <ying.huang@...ux.alibaba.com>, Feng Tang
	<feng.tang@...ux.alibaba.com>, <rafael@...nel.org>, Len Brown
	<lenb@...nel.org>, James Morse <james.morse@....com>, Tony Luck
	<tony.luck@...el.com>, <linux-acpi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, Ira Weiny <ira.weiny@...el.com>, Dave Jiang
	<dave.jiang@...el.com>, Dan Williams <dan.j.williams@...el.com>, Andi Kleen
	<ak@...ux.intel.com>
Subject: Re: [PATCH] APEI: GHES: Have GHES honor the panic= setting

Borislav Petkov wrote:
> The GHES driver overrides the panic= setting by force-rebooting the
> system after a fatal hw error has been reported. The intent being that
> such an error would be reported earlier.
> 
> However, this is not optimal when a hard-to-debug issue requires long
> time to reproduce and when that happens, the box will get rebooted after
> 30 seconds and thus destroy the whole hw context of when the error
> happened.
> 
> So rip out the default GHES panic timeout and honor the global one.
> 
> In the panic disabled (panic=0) case, the error will still be logged to
> dmesg for later inspection and if panic after a hw error is really
> required, then that can be controlled the usual way - use panic= on the
> cmdline or set it in the kernel .config's CONFIG_PANIC_TIMEOUT.
> 
> Reported-by: Feng Tang <feng.tang@...ux.alibaba.com>
> Signed-off-by: Borislav Petkov (AMD) <bp@...en8.de>
> Reviewed-by: Feng Tang <feng.tang@...ux.alibaba.com>

Reviewed-by: Ira Weiny <ira.weiny@...el.com>