linux-kernel - Re: [PATCH] APEI: GHES: Have GHES honor the panic= setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0irZKMEyxqh7Eekam91uoMcyEkMvZxmgqP4orRqg69nbQ@mail.gmail.com>
Date: Tue, 14 Jan 2025 18:29:13 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Ira Weiny <ira.weiny@...el.com>, Borislav Petkov <bp@...en8.de>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, "Huang, Ying" <ying.huang@...ux.alibaba.com>, 
	Feng Tang <feng.tang@...ux.alibaba.com>, Len Brown <lenb@...nel.org>, 
	James Morse <james.morse@....com>, Tony Luck <tony.luck@...el.com>, linux-acpi@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Dave Jiang <dave.jiang@...el.com>, 
	Dan Williams <dan.j.williams@...el.com>, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH] APEI: GHES: Have GHES honor the panic= setting

On Mon, Jan 13, 2025 at 9:08 PM Ira Weiny <ira.weiny@...el.com> wrote:
>
> Borislav Petkov wrote:
> > The GHES driver overrides the panic= setting by force-rebooting the
> > system after a fatal hw error has been reported. The intent being that
> > such an error would be reported earlier.
> >
> > However, this is not optimal when a hard-to-debug issue requires long
> > time to reproduce and when that happens, the box will get rebooted after
> > 30 seconds and thus destroy the whole hw context of when the error
> > happened.
> >
> > So rip out the default GHES panic timeout and honor the global one.
> >
> > In the panic disabled (panic=0) case, the error will still be logged to
> > dmesg for later inspection and if panic after a hw error is really
> > required, then that can be controlled the usual way - use panic= on the
> > cmdline or set it in the kernel .config's CONFIG_PANIC_TIMEOUT.
> >
> > Reported-by: Feng Tang <feng.tang@...ux.alibaba.com>
> > Signed-off-by: Borislav Petkov (AMD) <bp@...en8.de>
> > Reviewed-by: Feng Tang <feng.tang@...ux.alibaba.com>
>
> Reviewed-by: Ira Weiny <ira.weiny@...el.com>

Applied as 6.14 material, thanks!