linux-kernel - Re: [PATCH v5 0/5] perf test: Add a runs-per-test option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z4WTzkVh61cYoOsW@google.com>
Date: Mon, 13 Jan 2025 14:29:34 -0800
From: Namhyung Kim <namhyung@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Kan Liang <kan.liang@...ux.intel.com>,
	James Clark <james.clark@...aro.org>,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 0/5] perf test: Add a runs-per-test option

On Thu, Jan 09, 2025 at 08:57:31PM -0800, Ian Rogers wrote:
> Add a runs-per-test option to perf test inorder to better diagnose
> flakes. Each runs executes as if it were a different test, the tests
> appear together in the output:
> 
> ```
> $ perf test -r 3 lbr -v
> 122: perf record LBR tests                                           : Ok
> 122: perf record LBR tests                                           : Ok
> 122: perf record LBR tests                                           : Ok
> ```
> 
> v5: Fix the patch that updates the documentation for the sequential
>     option, as spotted by Namhyung.
> v4: Fix crash in dont_fork mode caused by cleanup work.
> v3: Improve perf test documentation, including for the new option, and
>     add some example output to the commit messages as requested by
>     Namhyung.
> v2: In the v1 patch Kan and I noted cleanup that would make the code
>     cleaner and less indented:
>     https://lore.kernel.org/lkml/20241109160219.49976-1-irogers@google.com/
>     Add patches doing some builtin-test.c cleanup and then add the
>     runs-per-test flag.
> 
> Ian Rogers (5):
>   perf test: Rename functions and variables for better clarity
>   perf test: Send list output to stdout rather than stderr
>   perf test: Fix parallel/sequential option documentation
>   perf test: Add a runs-per-test flag
>   perf test: Improve verbose documentation

Reviewed-by: Namhyung Kim <namhyung@...nel.org>

Thanks,
Namhyung

> 
>  tools/perf/Documentation/perf-test.txt |  20 ++-
>  tools/perf/tests/builtin-test.c        | 223 ++++++++++++-------------
>  2 files changed, 119 insertions(+), 124 deletions(-)
> 
> -- 
> 2.47.1.613.gc27f4b7a9f-goog
>