linux-kernel - Re: [PATCH v4 10/14] of: reserved-memory: Do not make kmemleak ignore freed address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <173681079939.3603903.12281721450645476296.robh@kernel.org>
Date: Mon, 13 Jan 2025 17:27:13 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Zijun Hu <zijun_hu@...oud.com>
Cc: Catalin Marinas <catalin.marinas@....com>,
	Robin Murphy <robin.murphy@....com>,
	Zijun Hu <quic_zijuhu@...cinc.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	Maxime Ripard <mripard@...nel.org>, linux-kernel@...r.kernel.org,
	Marc Zyngier <maz@...nel.org>, devicetree@...r.kernel.org,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Oreoluwa Babatunde <quic_obabatun@...cinc.com>,
	Andreas Herrmann <andreas.herrmann@...xeda.com>,
	Saravana Kannan <saravanak@...gle.com>,
	Mike Rapoport <rppt@...nel.org>
Subject: Re: [PATCH v4 10/14] of: reserved-memory: Do not make kmemleak
 ignore freed address


On Thu, 09 Jan 2025 21:27:01 +0800, Zijun Hu wrote:
> From: Zijun Hu <quic_zijuhu@...cinc.com>
> 
> early_init_dt_alloc_reserved_memory_arch() will free address @base when
> suffers memblock_mark_nomap() error, but it still makes kmemleak ignore
> the freed address @base via kmemleak_ignore_phys().
> 
> That is unnecessary, besides, also causes unnecessary warning messages:
> 
> kmemleak_ignore_phys()
>  -> make_black_object()
>     -> paint_ptr()
>        -> kmemleak_warn() // warning message here.
> 
> Fix by avoiding kmemleak_ignore_phys() when suffer the error.
> 
> Fixes: 658aafc8139c ("memblock: exclude MEMBLOCK_NOMAP regions from kmemleak")
> Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>
> ---
>  drivers/of/of_reserved_mem.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

Applied, thanks!