linux-kernel - Re: [PATCH 2/7] dt-bindings: phy: Add the M31 based eUSB2 PHY bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <173681084057.3609181.3813483305054365666.robh@kernel.org>
Date: Mon, 13 Jan 2025 17:27:22 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Melody Olvera <quic_molvera@...cinc.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
 Bjorn Andersson <andersson@...nel.org>, 
 Philipp Zabel <p.zabel@...gutronix.de>, Conor Dooley <conor+dt@...nel.org>, 
 Satya Durga Srinivasu Prabhala <quic_satyap@...cinc.com>, 
 linux-arm-msm@...r.kernel.org, Kishon Vijay Abraham I <kishon@...nel.org>, 
 Will Deacon <will@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Vinod Koul <vkoul@...nel.org>, linux-arm-kernel@...ts.infradead.org, 
 linux-usb@...r.kernel.org, Trilok Soni <quic_tsoni@...cinc.com>, 
 Konrad Dybcio <konradybcio@...nel.org>, linux-phy@...ts.infradead.org, 
 linux-kernel@...r.kernel.org, Catalin Marinas <catalin.marinas@....com>, 
 devicetree@...r.kernel.org, Wesley Cheng <quic_wcheng@...cinc.com>
Subject: Re: [PATCH 2/7] dt-bindings: phy: Add the M31 based eUSB2 PHY
 bindings


On Mon, 13 Jan 2025 13:52:08 -0800, Melody Olvera wrote:
> From: Wesley Cheng <quic_wcheng@...cinc.com>
> 
> On SM8750, the M31 eUSB2 PHY is being used to support USB2. Add the
> binding definition for the PHY driver.
> 
> Signed-off-by: Wesley Cheng <quic_wcheng@...cinc.com>
> Signed-off-by: Melody Olvera <quic_molvera@...cinc.com>
> ---
>  .../bindings/phy/qcom,m31-eusb2-phy.yaml           | 84 ++++++++++++++++++++++
>  1 file changed, 84 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/phy/qcom,m31-eusb2-phy.example.dts:18:18: fatal error: dt-bindings/clock/qcom,sm8750-gcc.h: No such file or directory
   18 |         #include <dt-bindings/clock/qcom,sm8750-gcc.h>
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/phy/qcom,m31-eusb2-phy.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1506: dt_binding_check] Error 2
make: *** [Makefile:251: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250113-sm8750_usb_master-v1-2-09afe1dc2524@quicinc.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.