linux-kernel - Re: [PATCH v4 1/3 RESEND] dt-bindings: can: fsl,flexcan: add S32G2/S32G3 SoC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <12a50b88-58ea-4df4-9770-68b1ab720d94@oss.nxp.com>
Date: Mon, 13 Jan 2025 15:53:40 +0200
From: Ciprian Marian Costea <ciprianmarian.costea@....nxp.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: devicetree@...r.kernel.org, linux-can@...r.kernel.org,
 Christophe Lizzi <clizzi@...hat.com>, imx@...ts.linux.dev,
 Enric Balletbo <eballetb@...hat.com>, Conor Dooley <conor+dt@...nel.org>,
 NXP S32 Linux <s32@....com>, Marc Kleine-Budde <mkl@...gutronix.de>,
 Vincent Mailhol <mailhol.vincent@...adoo.fr>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, linux-kernel@...r.kernel.org,
 Alberto Ruiz <aruizrui@...hat.com>
Subject: Re: [PATCH v4 1/3 RESEND] dt-bindings: can: fsl,flexcan: add
 S32G2/S32G3 SoC support

On 1/13/2025 3:46 PM, Rob Herring (Arm) wrote:
> 
> On Mon, 13 Jan 2025 14:07:02 +0200, Ciprian Costea wrote:
>> From: Ciprian Marian Costea <ciprianmarian.costea@....nxp.com>
>>
>> Add S32G2/S32G3 SoCs compatible strings.
>>
>> A particularity for these SoCs is the presence of separate interrupts for
>> state change, bus errors, MBs 0-7 and MBs 8-127 respectively.
>>
>> Increase maxItems of 'interrupts' to 4 for S32G based SoCs and keep the
>> same restriction for other SoCs.
>>
>> Also, as part of this commit, move the 'allOf' after the required
>> properties to make the documentation easier to read.
>>
>> Signed-off-by: Ciprian Marian Costea <ciprianmarian.costea@....nxp.com>
>> ---
>>   .../bindings/net/can/fsl,flexcan.yaml         | 44 +++++++++++++++++--
>>   1 file changed, 40 insertions(+), 4 deletions(-)
>>
> 
> 
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
> 
> If a tag was not added on purpose, please state why and what changed.
> 
> Missing tags:
> 
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> 
> 
> 

Hello Rob,

I just wanted to add the RESEND word to these patch series because no 
update was made with respect to its acceptance. Following [1] kernel 
documentation for submitting patches I was not sure if by adding the 
received 'Acked-by' to a commit it will still be correct to add the 
RESEND word or I should send a new patch version on this series.

On short, my lack of addition for the 'Acked-by' was not on purpose.

[1] https://docs.kernel.org/process/submitting-patches.html

Best Regards,
Ciprian