linux-kernel - Re: [PATCH v2] crypto: Use str_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3a50514d-2c28-4728-91d1-60ec91bcc2f9@linaro.org>
Date: Tue, 14 Jan 2025 20:05:50 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Herbert Xu <herbert@...dor.apana.org.au>,
 "David S. Miller" <davem@...emloft.net>, Horia Geantă
 <horia.geanta@....com>, Pankaj Gupta <pankaj.gupta@....com>,
 Gaurav Jain <gaurav.jain@....com>,
 Giovanni Cabiddu <giovanni.cabiddu@...el.com>,
 Boris Brezillon <bbrezillon@...nel.org>, Arnaud Ebalard <arno@...isbad.org>,
 Srujana Challa <schalla@...vell.com>, linux-crypto@...r.kernel.org,
 linux-kernel@...r.kernel.org, qat-linux@...el.com
Subject: Re: [PATCH v2] crypto: Use str_enable_disable-like helpers

On 14/01/2025 20:05, Krzysztof Kozlowski wrote:
> Replace ternary (condition ? "enable" : "disable") syntax with helpers
> from string_choices.h because:
> 1. Simple function call with one argument is easier to read.  Ternary
>    operator has three arguments and with wrapping might lead to quite
>    long code.
> 2. Is slightly shorter thus also easier to read.
> 3. It brings uniformity in the text - same string.
> 4. Allows deduping by the linker, which results in a smaller binary
>    file.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

And now I noted that should be here:

Acked-by: Giovanni Cabiddu <giovanni.cabiddu@...el.com> # QAT

Best regards,
Krzysztof